make validator more leniant for errors which are false instead of null

mhevery · mhevery · commit b2a8a089b6c3 · 2010-02-11T09:57:42.000-08:00
diff --git a/angular-minified.js b/angular-minified.js
diff --git a/angular.js b/angular.js
@@ -3490,7 +3490,7 @@ TextController.prototype = {
     }
     if (this.lastErrorText !== errorText) {
       this.lastErrorText = isValidationError;
-      if (errorText !== null && isVisible(view)) {
+      if (errorText && isVisible(view)) {
         view.setAttribute('ng-error', errorText);
         scope.markInvalid(this);
       }
diff --git a/src/Widgets.js b/src/Widgets.js
@@ -239,7 +239,7 @@ TextController.prototype = {
     }
     if (this.lastErrorText !== errorText) {
       this.lastErrorText = isValidationError;
-      if (errorText !== null && isVisible(view)) {
+      if (errorText && isVisible(view)) {
         view.setAttribute('ng-error', errorText);
         scope.markInvalid(this);
       }
diff --git a/test/WidgetsTest.js b/test/WidgetsTest.js
@@ -18,7 +18,7 @@ WidgetTest.prototype.testValidator = function () {
   var scope = new Scope({$invalidWidgets:[]});
   var cntl = new TextController(view[0], 'a', angularFormatter.noop);
   angular.validator.testValidator = function(value, expect){
-    return value == expect ? null : "Error text";
+    return value == expect ? false : "Error text";
   };
 
   scope.set('a', '');

Original file line number	Diff line number	Diff line change
`@@ -3490,7 +3490,7 @@ TextController.prototype = {`
`3490`	`3490`	`}`
`3491`	`3491`	`if (this.lastErrorText !== errorText) {`
`3492`	`3492`	`this.lastErrorText = isValidationError;`
`3493`		`- if (errorText !== null && isVisible(view)) {`
	`3493`	`+ if (errorText && isVisible(view)) {`
`3494`	`3494`	`view.setAttribute('ng-error', errorText);`
`3495`	`3495`	`scope.markInvalid(this);`
`3496`	`3496`	`}`
Original file line number	Diff line number	Diff line change
`@@ -239,7 +239,7 @@ TextController.prototype = {`
`239`	`239`	`}`
`240`	`240`	`if (this.lastErrorText !== errorText) {`
`241`	`241`	`this.lastErrorText = isValidationError;`
`242`		`- if (errorText !== null && isVisible(view)) {`
	`242`	`+ if (errorText && isVisible(view)) {`
`243`	`243`	`view.setAttribute('ng-error', errorText);`
`244`	`244`	`scope.markInvalid(this);`
`245`	`245`	`}`