fix($injector): check if a fn is an array explicitly

IgorMinar · IgorMinar · commit b1a6baac2de8 · 2014-06-23T17:19:41.000-07:00
This change makes the code easier to read and also fixes a compatibility issue with opal.js which pollutes the global state by setting $inject property on Array prototype Closes angular#7904 Closes angular#2653
diff --git a/src/auto/injector.js b/src/auto/injector.js
@@ -792,8 +792,7 @@ function createInjector(modulesToLoad, strictDi) {
           : getService(key)
         );
       }
-      if (!fn.$inject) {
-        // this means that we must be an array.
+      if (isArray(fn)) {
         fn = fn[length];
       }
 

Original file line number	Diff line number	Diff line change
`@@ -792,8 +792,7 @@ function createInjector(modulesToLoad, strictDi) {`
`792`	`792`	`: getService(key)`
`793`	`793`	`);`
`794`	`794`	`}`
`795`		`- if (!fn.$inject) {`
`796`		`- // this means that we must be an array.`
	`795`	`+ if (isArray(fn)) {`
`797`	`796`	`fn = fn[length];`
`798`	`797`	`}`
`799`	`798`