fix($location): don't rewrite when link is shift-clicked

caitp · petebacondarwin · commit 8b33de6fd0ec · 2015-01-25T00:34:35.000Z
Closes angular#9904 Closes angular#9906
diff --git a/src/ng/location.js b/src/ng/location.js
@@ -837,7 +837,7 @@ function $LocationProvider() {
       // TODO(vojta): rewrite link when opening in new tab/window (in legacy browser)
       // currently we open nice url link and redirect then
 
-      if (!html5Mode.rewriteLinks || event.ctrlKey || event.metaKey || event.which == 2 || event.button == 2) return;
+      if (!html5Mode.rewriteLinks || event.ctrlKey || event.metaKey || event.shiftKey || event.which == 2 || event.button == 2) return;
 
       var elm = jqLite(event.target);
 
diff --git a/test/ng/locationSpec.js b/test/ng/locationSpec.js
@@ -1539,6 +1539,19 @@ describe('$location', function() {
     });
 
 
+    it('should not rewrite when clicked with shift pressed', function() {
+      configureService({linkHref: 'base/a?b=c', html5Mode: true, supportHist: true});
+      inject(
+        initBrowser(),
+        initLocation(),
+        function($browser) {
+          browserTrigger(link, 'click', { keys: ['shift'] });
+          expectNoRewrite($browser);
+        }
+      );
+    });
+
+
     it('should not mess up hash urls when clicking on links in hashbang mode', function() {
       var base;
       module(function() {
