chore(version-info): remove console.logs and fix code style

petebacondarwin · petebacondarwin · commit 3130a82b2169 · 2015-01-30T21:25:14.000Z
diff --git a/lib/versions/version-info.js b/lib/versions/version-info.js
@@ -16,9 +16,9 @@ var currentPackage, previousVersions, cdnVersion, gitRepoInfo;
 var getPackage = function() {
   // Search up the folder hierarchy for the first package.json
   var packageFolder = path.resolve('.');
-  while ( !fs.existsSync(path.join(packageFolder, 'package.json')) ) {
+  while (!fs.existsSync(path.join(packageFolder, 'package.json'))) {
     var parent = path.dirname(packageFolder);
-    if ( parent === packageFolder) { break; }
+    if (parent === packageFolder) { break; }
     packageFolder = parent;
   }
   return JSON.parse(fs.readFileSync(path.join(packageFolder,'package.json'), 'UTF-8'));
@@ -48,11 +48,11 @@ var getGitRepoInfo = function() {
  * @return {String}         The codename if found, otherwise null/undefined
  */
 var getCodeName = function(tagName) {
-  var gitCatOutput = shell.exec('git cat-file -p '+ tagName, {silent:true}).output;
+  var gitCatOutput = shell.exec('git cat-file -p ' + tagName, {silent:true}).output;
   var tagMessage = gitCatOutput.match(/^.*codename.*$/mg)[0];
   var codeName = tagMessage && tagMessage.match(/codename\((.*)\)/)[1];
   if (!codeName) {
-    throw new Error("Could not extract release code name. The message of tag "+tagName+
+    throw new Error("Could not extract release code name. The message of tag " + tagName +
       " must match '*codename(some release name)*'");
   }
   return codeName;
@@ -65,7 +65,7 @@ var getCodeName = function(tagName) {
  */
 function getBuild() {
   var hash = shell.exec('git rev-parse --short HEAD', {silent: true}).output.replace('\n', '');
-  return 'sha.'+hash;
+  return 'sha.' + hash;
 }
 
 
@@ -76,11 +76,11 @@ function getBuild() {
 var getTaggedVersion = function() {
   var gitTagResult = shell.exec('git describe --exact-match', {silent:true});
 
-  if ( gitTagResult.code === 0 ) {
+  if (gitTagResult.code === 0) {
     var tag = gitTagResult.output.trim();
     var version = semver.parse(tag);
 
-    if ( version && semver.satisfies(version, currentPackage.branchVersion)) {
+    if (version && semver.satisfies(version, currentPackage.branchVersion)) {
       version.codeName = getCodeName(tag);
       version.full = version.version;
       version.branch = 'v' + currentPackage.branchPattern.replace('*', 'x');
@@ -102,7 +102,7 @@ var getPreviousVersions =  function() {
   var repo_url = currentPackage.repository.url;
   var tagResults = shell.exec('git ls-remote --tags ' + repo_url,
                               {silent: true});
-  if ( tagResults.code === 0 ) {
+  if (tagResults.code === 0) {
     return _(tagResults.output.match(/v[0-9].*[0-9]$/mg))
       .map(function(tag) {
         var version = semver.parse(tag);
@@ -112,7 +112,7 @@ var getPreviousVersions =  function() {
       .map(function(version) {
         version.docsUrl = 'http://code.angularjs.org/' + version.version + '/docs';
         // Versions before 1.0.2 had a different docs folder name
-        if ( version.major < 1 || (version.major === 1 && version.minor === 0 && version.dot < 2 ) ) {
+        if (version.major < 1 || (version.major === 1 && version.minor === 0 && version.dot < 2)) {
           version.docsUrl += '-' + version.version;
         }
         return version;
@@ -130,18 +130,14 @@ var getCdnVersion = function() {
       return semver.satisfies(tag, currentPackage.branchVersion);
     })
     .reverse()
-    .tap(function(versions) {
-      console.log(versions);
-    })
     .reduce(function(cdnVersion, version) {
       if (!cdnVersion) {
         // Note: need to use shell.exec and curl here
         // as version-infos returns its result synchronously...
-        var cdnResult = shell.exec('curl http://ajax.googleapis.com/ajax/libs/angularjs/'+version+'/angular.min.js '+
+        var cdnResult = shell.exec('curl http://ajax.googleapis.com/ajax/libs/angularjs/' + version + '/angular.min.js ' +
                   '--head --write-out "%{http_code}" -o /dev/null -silent',
                                     {silent: false});
-        console.log('http://ajax.googleapis.com/ajax/libs/angularjs/'+version+'/angular.min.js');
-        if ( cdnResult.code === 0 ) {
+        if (cdnResult.code === 0) {
           var statusCode = cdnResult.output.trim();
           if (statusCode === '200') {
             cdnVersion = version;
@@ -163,7 +159,7 @@ var getSnapshotVersion = function() {
     })
     .last();
 
-  if ( !version ) {
+  if (!version) {
     // a snapshot version before the first tag on the branch
     version = semver(currentPackage.branchPattern.replace('*','0-beta.1'));
   }
