refactor(hover): delete hover service

mhevery · IgorMinar · commit 1942861472a4 · 2011-10-11T10:53:06.000-07:00
diff --git a/angularFiles.js b/angularFiles.js
@@ -19,7 +19,6 @@ angularFiles = {
     'src/service/defer.js',
     'src/service/document.js',
     'src/service/exceptionHandler.js',
-    'src/service/hover.js',
     'src/service/invalidWidgets.js',
     'src/service/location.js',
     'src/service/log.js',
diff --git a/css/angular.css b/css/angular.css
@@ -19,68 +19,6 @@
   border: 2px solid #FF0000;
 }
 
-
-/*****************
- * TIP
- *****************/
-#ng-callout {
-  margin: 0;
-  padding: 0;
-  border: 0;
-  outline: 0;
-  font-size: 13px;
-  font-weight: normal;
-  font-family: Verdana, Arial, Helvetica, sans-serif;
-  vertical-align: baseline;
-  background: transparent;
-  text-decoration: none;
-}
-
-#ng-callout .ng-arrow-left{
-  background-image: url("data:image/gif;base64,R0lGODlhCwAXAKIAAMzMzO/v7/f39////////wAAAAAAAAAAACH5BAUUAAQALAAAAAALABcAAAMrSLoc/AG8FeUUIN+sGebWAnbKSJodqqlsOxJtqYooU9vvk+vcJIcTkg+QAAA7");
-  background-repeat: no-repeat;
-  background-position: left top;
-  position: absolute;
-  z-index:101;
-  left:-12px;
-  height:23px;
-  width:10px;
-  top:-3px;
-}
-
-#ng-callout .ng-arrow-right{
-  background-image: url("data:image/gif;base64,R0lGODlhCwAXAKIAAMzMzO/v7/f39////////wAAAAAAAAAAACH5BAUUAAQALAAAAAALABcAAAMrCLTcoM29yN6k9socs91e5X3EyJloipYrO4ohTMqA0Fn2XVNswJe+H+SXAAA7");
-  background-repeat: no-repeat;
-  background-position: left top;
-  position: absolute;
-  z-index:101;
-  height:23px;
-  width:11px;
-    top:-2px;
-}
-
-#ng-callout {
-  position: absolute;
-  z-index:100;
-  border: 2px solid #CCCCCC;
-  background-color: #fff;
-}
-
-#ng-callout .ng-content{
-  padding:10px 10px 10px 10px;
-  color:#333333;
-}
-
-#ng-callout .ng-title{
-  background-color: #CCCCCC;
-  text-align: left;
-  padding-left: 8px;
-  padding-bottom: 5px;
-  padding-top: 2px;
-  font-weight:bold;
-}
-
-
 /*****************
  * indicators
  *****************/
diff --git a/src/AngularPublic.js b/src/AngularPublic.js
@@ -6,7 +6,6 @@ angularService('$browser', function($log, $sniffer) {
   if (!browserSingleton) {
     browserSingleton = new Browser(window, jqLite(window.document), jqLite(window.document.body),
                                    XHR, $log, $sniffer);
-    browserSingleton.bind();
   }
   return browserSingleton;
 }, {$inject: ['$log', '$sniffer']});
diff --git a/src/Browser.js b/src/Browser.js
@@ -415,42 +415,6 @@ function Browser(window, document, body, XHR, $log, $sniffer) {
   //////////////////////////////////////////////////////////////
   // Misc API
   //////////////////////////////////////////////////////////////
-  var hoverListener = noop;
-
-  /**
-   * @workInProgress
-   * @ngdoc method
-   * @name angular.service.$browser#hover
-   * @methodOf angular.service.$browser
-   *
-   * @description
-   * Set hover listener.
-   *
-   * @param {function(Object, boolean)} listener Function that will be called when a hover event
-   *    occurs.
-   */
-  self.hover = function(listener) { hoverListener = listener; };
-
-  /**
-   * @workInProgress
-   * @ngdoc method
-   * @name angular.service.$browser#bind
-   * @methodOf angular.service.$browser
-   *
-   * @description
-   * Register hover function to real browser
-   */
-  self.bind = function() {
-    document.bind("mouseover", function(event){
-      hoverListener(jqLite(msie ? event.srcElement : event.target), true);
-      return true;
-    });
-    document.bind("mouseleave mouseout click dblclick keypress keyup", function(event){
-      hoverListener(jqLite(event.target), false);
-      return true;
-    });
-  };
-
 
   /**
    * @workInProgress
diff --git a/src/angular-mocks.js b/src/angular-mocks.js
@@ -328,9 +328,6 @@ MockBrowser.prototype = {
     return pollFn;
   },
 
-  hover: function(onHover) {
-  },
-
   url: function(url, replace) {
     if (url) {
       this.$$url = url;
diff --git a/src/service/hover.js b/src/service/hover.js
diff --git a/test/service/hoverSpec.js b/test/service/hoverSpec.js

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,6 @@ angularService('$browser', function($log, $sniffer) {`
`6`	`6`	`if (!browserSingleton) {`
`7`	`7`	`browserSingleton = new Browser(window, jqLite(window.document), jqLite(window.document.body),`
`8`	`8`	`XHR, $log, $sniffer);`
`9`		`- browserSingleton.bind();`
`10`	`9`	`}`
`11`	`10`	`return browserSingleton;`
`12`	`11`	`}, {$inject: ['$log', '$sniffer']});`