fix(copy): add support for copying Blob objects

gkalpak · gkalpak · commit 0b1b9112a341 · 2016-02-17T14:33:50.000+02:00
Although `copy()` does not need to (and never will) support all kinds of objects, there is a (not uncommon) usecase for supporting `Blob` objects: `ngMock`'s `$httpBackend` will return a copy of the response data (so that changes in one test won't affect others). Since returning `Blob` objects in response to HTTP requests is a valid usecase and since `ngMocks`'s `$httpBackend` will use `copy()` to create a copy of that data, it is reasonable to support `Blob` objects. (I didn't run any benchmarks, but the additional check for the type of the copied element should have negligible impact, compared to the other stuff that `copy()` is doing.) Fixes angular#9669 Closes angular#14064
diff --git a/src/Angular.js b/src/Angular.js
@@ -913,6 +913,9 @@ function copy(source, destination) {
         var re = new RegExp(source.source, source.toString().match(/[^\/]*$/)[0]);
         re.lastIndex = source.lastIndex;
         return re;
+
+      case '[object Blob]':
+        return new source.constructor([source], {type: source.type});
     }
 
     if (isFunction(source.cloneNode)) {
diff --git a/test/AngularSpec.js b/test/AngularSpec.js
@@ -228,6 +228,18 @@ describe('angular', function() {
       }
     });
 
+    it('should handle Blob objects', function() {
+      if (typeof Blob !== 'undefined') {
+        var src = new Blob(['foo'], {type: 'bar'});
+        var dst = copy(src);
+
+        expect(dst).not.toBe(src);
+        expect(dst.size).toBe(3);
+        expect(dst.type).toBe('bar');
+        expect(isBlob(dst)).toBe(true);
+      }
+    });
+
     it("should throw an exception if a Uint8Array is the destination", function() {
       if (typeof Uint8Array !== 'undefined') {
         var src = new Uint8Array();
diff --git a/test/ngMock/angular-mocksSpec.js b/test/ngMock/angular-mocksSpec.js
@@ -1011,6 +1011,26 @@ describe('ngMock', function() {
     });
 
 
+    it('should be able to handle Blobs as mock data', function() {
+      if (typeof Blob !== 'undefined') {
+        var mockBlob = new Blob(['{"foo":"bar"}'], {type: 'application/json'});
+
+        hb.when('GET', '/url1').respond(200, mockBlob, {});
+
+        callback.andCallFake(function(status, response) {
+          expect(response).not.toBe(mockBlob);
+          expect(response.size).toBe(13);
+          expect(response.type).toBe('application/json');
+          expect(response.toString()).toBe('[object Blob]');
+        });
+
+        hb('GET', '/url1', null, callback);
+        hb.flush();
+        expect(callback).toHaveBeenCalledOnce();
+      }
+    });
+
+
     it('should throw error when unexpected request', function() {
       hb.when('GET', '/url1').respond(200, 'content');
       expect(function() {

Original file line number	Diff line number	Diff line change
`@@ -913,6 +913,9 @@ function copy(source, destination) {`
`913`	`913`	`var re = new RegExp(source.source, source.toString().match(/[^\/]*$/)[0]);`
`914`	`914`	`re.lastIndex = source.lastIndex;`
`915`	`915`	`return re;`
	`916`	`+`
	`917`	`+ case '[object Blob]':`
	`918`	`+ return new source.constructor([source], {type: source.type});`
`916`	`919`	`}`
`917`	`920`
`918`	`921`	`if (isFunction(source.cloneNode)) {`