X Tutup
Skip to content

Commit e950dd6

Browse files
jeffbcrossIgorMinar
authored andcommitted
refactor(bundles): make rxjs an external dependency in umd bundle
Closes angular#5886 Closes angular#5893
1 parent 321ed7d commit e950dd6

File tree

1 file changed

+29
-1
lines changed

1 file changed

+29
-1
lines changed

gulpfile.js

Lines changed: 29 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1143,7 +1143,35 @@ gulp.task('!bundles.js.umd', ['build.js.dev'], function() {
11431143
resolve: resolveOptions(devOrProd),
11441144
module: {preLoaders: [{test: /\.js$/, loader: 'source-map-loader'}]},
11451145
devtool: devOrProd === 'dev' ? 'inline-source-map' : undefined,
1146-
output: outputOptions(outFileName, devOrProd)
1146+
output: outputOptions(outFileName, devOrProd),
1147+
externals: {
1148+
'rxjs/Observable': 'umd Rx',
1149+
'rxjs/Subject': 'umd Rx',
1150+
'rxjs/subject/ReplaySubject': {
1151+
commonjs: 'rxjs/subject/ReplaySubject',
1152+
commonjs2: 'rxjs/subject/ReplaySubject',
1153+
amd: 'rxjs/subject/ReplaySubject',
1154+
root: ['Rx']
1155+
},
1156+
'rxjs/operator/take': {
1157+
commonjs: 'rxjs/operator/take',
1158+
commonjs2: 'rxjs/operator/take',
1159+
amd: 'rxjs/operator/take',
1160+
root: ['Rx', 'Observable', 'prototype']
1161+
},
1162+
'rxjs/observable/fromPromise': {
1163+
commonjs: 'rxjs/observable/fromPromise',
1164+
commonjs2: 'rxjs/observable/fromPromise',
1165+
amd: 'rxjs/observable/fromPromise',
1166+
root: ['Rx', 'Observable']
1167+
},
1168+
'rxjs/operator/toPromise': {
1169+
commonjs: 'rxjs/operator/toPromise',
1170+
commonjs2: 'rxjs/operator/toPromise',
1171+
amd: 'rxjs/operator/toPromise',
1172+
root: ['Rx', 'Observable', 'prototype']
1173+
}
1174+
}
11471175
};
11481176
}
11491177

0 commit comments

Comments
 (0)
X Tutup