X Tutup
Skip to content

Commit e1bf3d3

Browse files
juliemralexeagle
juliemr
authored and
alexeagle
committed
feat(debug): replace DebugElement with new Debug DOM
Now, using `ng.probe(element)` in the browser console returns a DebugElement when in dev mode. `ComponentFixture#debugElement` also returns a new DebugElement. Breaking Change: This is a breaking change for unit tests. The API for the DebugElement has changed. Now, there is a DebugElement or DebugNode for every node in the DOM, not only nodes with an ElementRef. `componentViewChildren` is removed, and `childNodes` is a list of ElementNodes corresponding to every child in the DOM. `query` no longer takes a scope parameter, since the entire rendered DOM is included in the `childNodes`. Before: ``` componentFixture.debugElement.componentViewChildren[0]; ``` After ``` // Depending on the DOM structure of your component, the // index may have changed or the first component child // may be a sub-child. componentFixture.debugElement.children[0]; ``` Before: ``` debugElement.query(By.css('div'), Scope.all()); ``` After: ``` debugElement.query(By.css('div')); ``` Before: ``` componentFixture.debugElement.elementRef; ``` After: ``` componentFixture.elementRef; ```
1 parent ae7d2ab commit e1bf3d3

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

45 files changed

+1233
-1210
lines changed

‎modules/angular2/core.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export './src/core/application_tokens.dart' show APP_ID,
1515
export './src/core/zone.dart';
1616
export './src/core/render.dart';
1717
export './src/core/linker.dart';
18-
export './src/core/debug/debug_element.dart' show DebugElement,
18+
export './src/core/debug/debug_node.dart' show DebugElement,
1919
Scope,
2020
inspectElement,
2121
asNativeElements;

‎modules/angular2/core.ts‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,7 @@ export {
2020
export * from './src/core/zone';
2121
export * from './src/core/render';
2222
export * from './src/core/linker';
23-
export {
24-
DebugElement,
25-
Scope,
26-
inspectElement,
27-
asNativeElements
28-
} from './src/core/debug/debug_element';
23+
export {DebugElement, asNativeElements} from './src/core/debug/debug_node';
2924
export * from './src/core/testability/testability';
3025
export * from './src/core/change_detection';
3126
export * from './src/core/platform_directives_and_pipes';

‎modules/angular2/examples/core/debug/ts/debug_element/debug_element.ts‎

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,8 @@
1-
import {DebugElement, Scope} from 'angular2/core';
1+
import {DebugElement} from 'angular2/core';
22

33
var debugElement: DebugElement;
44
var predicate;
55

66
// #docregion scope_all
7-
debugElement.query(predicate, Scope.all);
8-
// #enddocregion
9-
10-
// #docregion scope_light
11-
debugElement.query(predicate, Scope.light);
12-
// #enddocregion
13-
14-
// #docregion scope_view
15-
debugElement.query(predicate, Scope.view);
7+
debugElement.query(predicate);
168
// #enddocregion

‎modules/angular2/examples/platform/dom/debug/ts/by/by.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
import {By} from 'angular2/platform/browser';
2-
import {DebugElement, Scope} from 'angular2/core';
2+
import {DebugElement} from 'angular2/core';
33

44
var debugElement: DebugElement;
55
class MyDirective {}
66

77
// #docregion by_all
8-
debugElement.query(By.all(), Scope.all);
8+
debugElement.query(By.all());
99
// #enddocregion
1010

1111
// #docregion by_css
12-
debugElement.query(By.css('[attribute]'), Scope.all);
12+
debugElement.query(By.css('[attribute]'));
1313
// #enddocregion
1414

1515
// #docregion by_directive
16-
debugElement.query(By.directive(MyDirective), Scope.all);
16+
debugElement.query(By.directive(MyDirective));
1717
// #enddocregion

‎modules/angular2/platform/browser.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
export {AngularEntrypoint} from 'angular2/src/core/angular_entrypoint';
22
export {
33
BROWSER_PROVIDERS,
4-
ELEMENT_PROBE_BINDINGS,
54
ELEMENT_PROBE_PROVIDERS,
5+
ELEMENT_PROBE_PROVIDERS_PROD_MODE,
66
inspectNativeElement,
77
BrowserDomAdapter,
88
By,

‎modules/angular2/platform/browser_static.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
export {AngularEntrypoint} from 'angular2/src/core/angular_entrypoint';
22
export {
33
BROWSER_PROVIDERS,
4-
ELEMENT_PROBE_BINDINGS,
54
ELEMENT_PROBE_PROVIDERS,
5+
ELEMENT_PROBE_PROVIDERS_PROD_MODE,
66
inspectNativeElement,
77
BrowserDomAdapter,
88
By,

‎modules/angular2/platform/common_dom.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@ export {
1212
EventManagerPlugin
1313
} from 'angular2/src/platform/dom/events/event_manager';
1414
export * from 'angular2/src/platform/dom/debug/by';
15-
export * from 'angular2/src/platform/dom/debug/debug_element_view_listener';
15+
export * from 'angular2/src/platform/dom/debug/ng_probe';

‎modules/angular2/src/core/application_common_providers.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import {ResolvedMetadataCache} from 'angular2/src/core/linker/resolved_metadata_
1515
import {AppViewManager} from './linker/view_manager';
1616
import {AppViewManager_} from "./linker/view_manager";
1717
import {ViewResolver} from './linker/view_resolver';
18-
import {AppViewListener} from './linker/view_listener';
1918
import {DirectiveResolver} from './linker/directive_resolver';
2019
import {PipeResolver} from './linker/pipe_resolver';
2120
import {Compiler} from './linker/compiler';
@@ -32,7 +31,6 @@ export const APPLICATION_COMMON_PROVIDERS: Array<Type | Provider | any[]> = CONS
3231
APP_ID_RANDOM_PROVIDER,
3332
ResolvedMetadataCache,
3433
new Provider(AppViewManager, {useClass: AppViewManager_}),
35-
AppViewListener,
3634
ViewResolver,
3735
new Provider(IterableDiffers, {useValue: defaultIterableDiffers}),
3836
new Provider(KeyValueDiffers, {useValue: defaultKeyValueDiffers}),

‎modules/angular2/src/core/debug/debug_element.ts‎

Lines changed: 0 additions & 248 deletions
This file was deleted.

0 commit comments

Comments
 (0)
X Tutup