refactor(dart/transform): Error in name convert funcs on unexpected input

Tim Blasi · kegluneq · commit cfef76f683dd · 2016-02-02T23:46:27.000Z
Issue raised in PR angular#6745. Previously, the transformer name conversion functions could return the input string on unexpected input, which is almost certainly an error. `throw` in this case instead, so we know early that something has likely gone wrong. Closes angular#6753
diff --git a/modules_dart/transform/lib/src/transform/common/names.dart b/modules_dart/transform/lib/src/transform/common/names.dart
@@ -84,5 +84,9 @@ String _toExtension(
           '$toExtension';
     }
   }
-  return uri;
+  throw new ArgumentError.value(
+      uri,
+      'uri',
+      'Provided value ends with an unexpected extension. '
+      'Expected extension(s): [${fromExtensions.join(', ')}].');
 }

Original file line number	Diff line number	Diff line change
`@@ -84,5 +84,9 @@ String _toExtension(`
`84`	`84`	`'$toExtension';`
`85`	`85`	`}`
`86`	`86`	`}`
`87`		`- return uri;`
	`87`	`+ throw new ArgumentError.value(`
	`88`	`+ uri,`
	`89`	`+ 'uri',`
	`90`	`+ 'Provided value ends with an unexpected extension. '`
	`91`	`+ 'Expected extension(s): [${fromExtensions.join(', ')}].');`
`88`	`92`	`}`