fix(typings): fix typings which were previously unchecked

alexeagle · alexeagle · commit c178ad476e52 · 2015-10-09T16:23:30.000Z
Closes angular#4625
diff --git a/modules/angular2/src/core/directives/ng_class.ts b/modules/angular2/src/core/directives/ng_class.ts
@@ -108,12 +108,12 @@ export class NgClass implements DoCheck, OnDestroy {
     this._initialClasses.forEach(className => this._toggleClass(className, !isCleanup));
   }
 
-  private _applyClasses(rawClassVal, isCleanup: boolean) {
+  private _applyClasses(rawClassVal: string[] | {[key: string]: string}, isCleanup: boolean) {
     if (isPresent(rawClassVal)) {
       if (isListLikeIterable(rawClassVal)) {
         (<string[]>rawClassVal).forEach(className => this._toggleClass(className, !isCleanup));
       } else {
-        StringMapWrapper.forEach(rawClassVal, (expVal, className) => {
+        StringMapWrapper.forEach(<{[k: string]: string}>rawClassVal, (expVal, className) => {
           if (expVal) this._toggleClass(className, !isCleanup);
         });
       }
diff --git a/modules/angular2/src/core/linker/element_injector.ts b/modules/angular2/src/core/linker/element_injector.ts
@@ -212,13 +212,15 @@ function _createProtoQueryRefs(bindings: BindingWithVisibility[]): ProtoQueryRef
   var res = [];
   ListWrapper.forEachWithIndex(bindings, (b, i) => {
     if (b.binding instanceof DirectiveBinding) {
+      var directiveBinding = <DirectiveBinding>b.binding;
       // field queries
-      var queries: QueryMetadataWithSetter[] = b.binding.queries;
+      var queries: QueryMetadataWithSetter[] = directiveBinding.queries;
       queries.forEach(q => res.push(new ProtoQueryRef(i, q.setter, q.metadata)));
 
       // queries passed into the constructor.
       // TODO: remove this after constructor queries are no longer supported
-      var deps: DirectiveDependency[] = b.binding.resolvedFactories[0].dependencies;
+      var deps: DirectiveDependency[] =
+          <DirectiveDependency[]>directiveBinding.resolvedFactory.dependencies;
       deps.forEach(d => {
         if (isPresent(d.queryDecorator)) res.push(new ProtoQueryRef(i, null, d.queryDecorator));
       });
diff --git a/modules/benchpress/src/metric/multi_metric.ts b/modules/benchpress/src/metric/multi_metric.ts
@@ -42,7 +42,7 @@ export class MultiMetric extends Metric {
   }
 }
 
-function mergeStringMaps(maps: any[]): Object {
+function mergeStringMaps(maps: { [key: string]: string }[]): Object {
   var result = {};
   maps.forEach(
       map => { StringMapWrapper.forEach(map, (value, prop) => { result[prop] = value; }); });
diff --git a/modules/benchpress/src/metric/perflog_metric.ts b/modules/benchpress/src/metric/perflog_metric.ts
@@ -142,7 +142,7 @@ export class PerflogMetric extends Metric {
     });
   }
 
-  _addEvents(events: any[]) {
+  _addEvents(events: { [key: string]: string }[]) {
     var needSort = false;
     events.forEach(event => {
       if (StringWrapper.equals(event['ph'], 'X')) {
diff --git a/modules/benchpress/src/statistic.ts b/modules/benchpress/src/statistic.ts
@@ -5,14 +5,14 @@ export class Statistic {
     return Statistic.calculateStandardDeviation(sample, mean) / mean * 100;
   }
 
-  static calculateMean(samples: any[]) {
+  static calculateMean(samples: number[]) {
     var total = 0;
     // TODO: use reduce
     samples.forEach(x => total += x);
     return total / samples.length;
   }
 
-  static calculateStandardDeviation(samples: any[], mean) {
+  static calculateStandardDeviation(samples: number[], mean) {
     var deviation = 0;
     // TODO: use reduce
     samples.forEach(x => deviation += Math.pow(x - mean, 2));

Original file line number	Diff line number	Diff line change
`@@ -108,12 +108,12 @@ export class NgClass implements DoCheck, OnDestroy {`
`108`	`108`	`this._initialClasses.forEach(className => this._toggleClass(className, !isCleanup));`
`109`	`109`	`}`
`110`	`110`
`111`		`- private _applyClasses(rawClassVal, isCleanup: boolean) {`
	`111`	`+ private _applyClasses(rawClassVal: string[] \| {[key: string]: string}, isCleanup: boolean) {`
`112`	`112`	`if (isPresent(rawClassVal)) {`
`113`	`113`	`if (isListLikeIterable(rawClassVal)) {`
`114`	`114`	`(<string[]>rawClassVal).forEach(className => this._toggleClass(className, !isCleanup));`
`115`	`115`	`} else {`
`116`		`- StringMapWrapper.forEach(rawClassVal, (expVal, className) => {`
	`116`	`+ StringMapWrapper.forEach(<{[k: string]: string}>rawClassVal, (expVal, className) => {`
`117`	`117`	`if (expVal) this._toggleClass(className, !isCleanup);`
`118`	`118`	`});`
`119`	`119`	`}`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ export class MultiMetric extends Metric {`
`42`	`42`	`}`
`43`	`43`	`}`
`44`	`44`
`45`		`-function mergeStringMaps(maps: any[]): Object {`
	`45`	`+function mergeStringMaps(maps: { [key: string]: string }[]): Object {`
`46`	`46`	`var result = {};`
`47`	`47`	`maps.forEach(`
`48`	`48`	`map => { StringMapWrapper.forEach(map, (value, prop) => { result[prop] = value; }); });`
Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,7 @@ export class PerflogMetric extends Metric {`
`142`	`142`	`});`
`143`	`143`	`}`
`144`	`144`
`145`		`- _addEvents(events: any[]) {`
	`145`	`+ _addEvents(events: { [key: string]: string }[]) {`
`146`	`146`	`var needSort = false;`
`147`	`147`	`events.forEach(event => {`
`148`	`148`	`if (StringWrapper.equals(event['ph'], 'X')) {`