docs(core): make naming concrete

timruffles · jelbourn · commit bdfed9d850d6 · 2015-12-02T11:41:52.000-08:00
I think people new to promises, angular etc will find this example easier to understand with concrete identifiers from a simple use-case. The existing naming could be confused with promise/angular functionality (`promise` in the template, `resolved` etc).

Also I made `resolve` private, as then it's clear what we're exposing for the template.
diff --git a/modules/angular2/examples/core/pipes/ts/async_pipe/async_pipe_example.ts b/modules/angular2/examples/core/pipes/ts/async_pipe/async_pipe_example.ts
@@ -5,28 +5,29 @@ import {bootstrap} from 'angular2/bootstrap';
 @Component({
   selector: 'async-example',
   template: `<div>
-    <p>Wait for it... {{promise | async}}</p>
-    <button (click)="clicked()">{{resolved ? 'Reset' : 'Resolve'}}</button> 
+    <p>Wait for it... {{ greeting | async }}</p>
+    <button (click)="clicked()">{{ arrived ? 'Reset' : 'Resolve' }}</button> 
   </div>`
 })
 export class AsyncPipeExample {
-  resolved: boolean = false;
-  promise: Promise<string> = null;
-  resolve: Function = null;
+  greeting: Promise<string> = null;
+  arrived: boolean = false;
+
+  private resolve: Function = null;
 
   constructor() { this.reset(); }
 
   reset() {
-    this.resolved = false;
-    this.promise = new Promise<string>((resolve, reject) => { this.resolve = resolve; });
+    this.arrived = false;
+    this.greeting = new Promise<string>((resolve, reject) => { this.resolve = resolve; });
   }
 
   clicked() {
-    if (this.resolved) {
+    if (this.arrived) {
       this.reset();
     } else {
-      this.resolve("resolved!");
-      this.resolved = true;
+      this.resolve("hi there!");
+      this.arrived = true;
     }
   }
 }
