X Tutup
Skip to content

Commit 9d28147

Browse files
committed
fix(benchpress): fix flake
memory was not allocated to be high enough, resulting in partial results to be clipped, and therefore failing the assertions Closes angular#6161
1 parent d116861 commit 9d28147

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

modules/benchpress/src/firefox_extension/lib/main.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ mod.PageMod({
5454
contentScriptFile: data.url('installed_script.js'),
5555
onAttach: worker => {
5656
worker.port.on('startProfiler',
57-
(timeStarted) => profiler.start(/* = profiler memory */ 1000000, 0.1,
57+
(timeStarted) => profiler.start(/* = profiler memory */ 3000000, 0.1,
5858
['leaf', 'js', 'stackwalk', 'gc'], timeStarted));
5959
worker.port.on('stopProfiler', () => profiler.stop());
6060
worker.port.on('getProfile',

modules/benchpress/test/firefox_extension/spec.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ describe('firefox extension', function() {
2424
browser.executeScript('window.startProfiler()')
2525
.then(function() { console.log('started measuring perf'); });
2626

27+
browser.executeAsyncScript('setTimeout(arguments[0], 1000);');
2728
browser.executeScript('window.forceGC()');
2829

2930
browser.executeAsyncScript('var cb = arguments[0]; window.getProfile(cb);')

scripts/ci/test_e2e_js.sh

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,5 @@ fi
3030

3131
./node_modules/.bin/protractor protractor-js.conf.js $OPTIONS
3232
./node_modules/.bin/protractor protractor-js.conf.js $OPTIONS --benchmark --dryrun
33-
# TODO(tbosch): tests for benchpress on firefox are disabled
34-
# as they are very flake. Enable once https://github.com/angular/angular/issues/5611
35-
# is resolved.
36-
# ./node_modules/.bin/protractor dist/js/cjs/benchpress/test/firefox_extension/conf.js
33+
./node_modules/.bin/protractor dist/js/cjs/benchpress/test/firefox_extension/conf.js
3734

0 commit comments

Comments
 (0)
X Tutup