feat(dart/transform): Do not re-process generated files

Tim Blasi · Tim Blasi · commit 8f91ff84c7c1 · 2015-11-12T11:23:19.000-08:00
In the `DeferredRewriter` phase, do not process files which were
generated by the transformer, since these will never need to be
rewritten.
diff --git a/modules_dart/transform/lib/src/transform/common/names.dart b/modules_dart/transform/lib/src/transform/common/names.dart
@@ -30,6 +30,20 @@ const ALL_EXTENSIONS = const [
   '.dart'
 ];
 
+/// Whether `uri` was created by a transform phase.
+///
+/// This may return false positives for problematic inputs.
+/// This just tests file extensions known to be created by the transformer, so
+/// any files named like transformer outputs will be reported as generated.
+bool isGenerated(String uri) {
+  return const [
+    DEPS_EXTENSION,
+    NON_SHIMMED_STYLESHEET_EXTENSION,
+    SHIMMED_STYLESHEET_EXTENSION,
+    TEMPLATE_EXTENSION,
+  ].any((ext) => uri.endsWith(ext));
+}
+
 /// Returns `uri` with its extension updated to [META_EXTENSION].
 String toMetaExtension(String uri) =>
     _toExtension(uri, ALL_EXTENSIONS, META_EXTENSION);
diff --git a/modules_dart/transform/lib/src/transform/deferred_rewriter/transformer.dart b/modules_dart/transform/lib/src/transform/deferred_rewriter/transformer.dart
@@ -21,7 +21,7 @@ class DeferredRewriter extends Transformer {
 
   @override
   bool isPrimary(AssetId id) =>
-      id.extension.endsWith('dart') && !id.path.endsWith(DEPS_EXTENSION);
+      id.extension.endsWith('dart') && _isNotGenerated(id);
 
   @override
   Future apply(Transform transform) async {
@@ -36,6 +36,8 @@ class DeferredRewriter extends Transformer {
   }
 }
 
+bool _isNotGenerated(AssetId id) => !isGenerated(id.path);
+
 // Visible for testing
 Future<String> rewriteDeferredLibraries(AssetReader reader, AssetId id) async {
   var rewriter = new Rewriter(id, reader);

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ class DeferredRewriter extends Transformer {`
`21`	`21`
`22`	`22`	`@override`
`23`	`23`	`bool isPrimary(AssetId id) =>`
`24`		`- id.extension.endsWith('dart') && !id.path.endsWith(DEPS_EXTENSION);`
	`24`	`+ id.extension.endsWith('dart') && _isNotGenerated(id);`
`25`	`25`
`26`	`26`	`@override`
`27`	`27`	`Future apply(Transform transform) async {`
`@@ -36,6 +36,8 @@ class DeferredRewriter extends Transformer {`
`36`	`36`	`}`
`37`	`37`	`}`
`38`	`38`
	`39`	`+bool _isNotGenerated(AssetId id) => !isGenerated(id.path);`
	`40`	`+`
`39`	`41`	`// Visible for testing`
`40`	`42`	`Future<String> rewriteDeferredLibraries(AssetReader reader, AssetId id) async {`
`41`	`43`	`var rewriter = new Rewriter(id, reader);`