X Tutup
Skip to content

Commit 80b025a

Browse files
IgorMinarjelbourn
authored andcommitted
build(broccoli): convert dependencies to peerDependencies in all package.json templates
This is more correct and resolves the issue of having dupes within the same project. This change has no impact on our shrinkwrap since peerDeps and deps are merged into one within the shrinkwrap file. BREAKING CHANGE: rxjs, reflect-metadata, zone.js and es6-shims now must be specified as explicit dependencies of each angular app that uses npm for package management. To migrate, please add the following into the "dependencies" section of your package.json: ``` "dependencies": { ... "es6-promise": "^3.0.2", "es6-shim": "^0.33.3", "reflect-metadata": "0.1.2", "rxjs": "5.0.0-alpha.11", "zone.js": "0.5.8" ... } ``` Closes angular#5560 Closes angular#5649
1 parent 11f98c5 commit 80b025a

File tree

4 files changed

+20
-10
lines changed

4 files changed

+20
-10
lines changed

modules/angular2/package.json

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,12 @@
77
"contributors": <%= JSON.stringify(packageJson.contributors) %>,
88
"license": "<%= packageJson.license %>",
99
"repository": <%= JSON.stringify(packageJson.repository) %>,
10-
"dependencies": {
10+
"devDependencies": <%= JSON.stringify(packageJson.defaultDevDependencies) %>,
11+
"peerDependencies": {
12+
"es6-promise": "<%= packageJson.dependencies['es6-promise'] %>",
13+
"es6-shim": "<%= packageJson.dependencies['es6-shim'] %>",
1114
"reflect-metadata": "<%= packageJson.dependencies['reflect-metadata'] %>",
1215
"rxjs": "<%= packageJson.dependencies['rxjs'] %>",
1316
"zone.js": "<%= packageJson.dependencies['zone.js'] %>"
14-
},
15-
"devDependencies": <%= JSON.stringify(packageJson.defaultDevDependencies) %>
17+
}
1618
}

modules/angular2/src/http/package.json

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,9 @@
77
"contributors": <%= JSON.stringify(packageJson.contributors) %>,
88
"license": "<%= packageJson.license %>",
99
"repository": <%= JSON.stringify(packageJson.repository) %>,
10-
"dependencies": {
11-
"angular2": "<%= packageJson.version %>",
12-
"rxjs": "<%= packageJson.dependencies['rxjs'] %>",
13-
"reflect-metadata": "<%= packageJson.dependencies['reflect-metadata'] %>"
14-
},
1510
"devDependencies": <%= JSON.stringify(packageJson.defaultDevDependencies) %>
11+
"peerDependencies": {
12+
"angular2": "<%= packageJson.version %>",
13+
"rxjs": "<%= packageJson.dependencies['rxjs'] %>"
14+
}
1615
}

modules/angular2_material/package.json

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,14 @@
88
"license": "<%= packageJson.license %>",
99
"repository": <%= JSON.stringify(packageJson.repository) %>,
1010
"dependencies": {
11-
"angular2": "<%= packageJson.version %>",
11+
"es6-promise": "<%= packageJson.dependencies['es6-promise'] %>",
12+
"es6-shim": "<%= packageJson.dependencies['es6-shim'] %>",
13+
"reflect-metadata": "<%= packageJson.dependencies['reflect-metadata'] %>",
1214
"rxjs": "<%= packageJson.dependencies['rxjs'] %>",
1315
"zone.js": "<%= packageJson.dependencies['zone.js'] %>"
1416
},
1517
"devDependencies": <%= JSON.stringify(packageJson.defaultDevDependencies) %>
18+
"peerDependencies": {
19+
"angular2": "<%= packageJson.version %>"
20+
}
1621
}

modules/benchpress/package.json

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,12 @@
1010
"repository": <%= JSON.stringify(packageJson.repository) %>,
1111
"dependencies": {
1212
"angular2": "<%= packageJson.version %>",
13+
"es6-promise": "<%= packageJson.dependencies['es6-promise'] %>",
14+
"es6-shim": "<%= packageJson.dependencies['es6-shim'] %>",
15+
"reflect-metadata": "<%= packageJson.dependencies['reflect-metadata'] %>",
16+
"rxjs": "<%= packageJson.dependencies['rxjs'] %>",
1317
"selenium-webdriver": "<%= packageJson.dependencies['selenium-webdriver'] %>",
14-
"reflect-metadata": "<%= packageJson.dependencies['reflect-metadata'] %>"
18+
"zone.js": "<%= packageJson.dependencies['zone.js'] %>"
1519
},
1620
"optionalDependencies": {
1721
"jpm": "<%= packageJson.devDependencies.jpm %>",

0 commit comments

Comments
 (0)
X Tutup