feat(http): call complete on request complete

PatrickJS · jeffbcross · commit 6fac90115176 · 2015-07-28T11:45:15.000-07:00
closes angular#2635
diff --git a/modules/angular2/src/http/backends/xhr_backend.ts b/modules/angular2/src/http/backends/xhr_backend.ts
@@ -43,6 +43,8 @@ export class XHRConnection implements Connection {
       }
 
       ObservableWrapper.callNext(this.response, new Response(responseOptions));
+      // TODO(gdi2290): defer complete if array buffer until done
+      ObservableWrapper.callReturn(this.response);
     });
     // TODO(jeffbcross): make this more dynamic based on body type
 
diff --git a/modules/angular2/test/http/backends/xhr_backend_spec.ts b/modules/angular2/test/http/backends/xhr_backend_spec.ts
@@ -95,6 +95,16 @@ export function main() {
            existingXHRs[0].dispatchEvent('load');
          }));
 
+      it('should complete a request', inject([AsyncTestCompleter], async => {
+           var connection = new XHRConnection(sampleRequest, new MockBrowserXHR(),
+                                              new ResponseOptions({type: ResponseTypes.Error}));
+           ObservableWrapper.subscribe<Response>(connection.response, res => {
+             expect(res.type).toBe(ResponseTypes.Error);
+           }, null, () => { async.done(); });
+
+           existingXHRs[0].dispatchEvent('load');
+         }));
+
       it('should call abort when disposed', () => {
         var connection = new XHRConnection(sampleRequest, new MockBrowserXHR());
         connection.dispose();

Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,8 @@ export class XHRConnection implements Connection {`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`ObservableWrapper.callNext(this.response, new Response(responseOptions));`
	`46`	`+ // TODO(gdi2290): defer complete if array buffer until done`
	`47`	`+ ObservableWrapper.callReturn(this.response);`
`46`	`48`	`});`
`47`	`49`	`// TODO(jeffbcross): make this more dynamic based on body type`
`48`	`50`