refactor(RuntimeMetadataResolver): simplify the code

vicb · vicb · commit 3416984cce99 · 2015-10-27T01:16:46.000Z
Closes angular#4874
diff --git a/modules/angular2/src/core/compiler/runtime_metadata.ts b/modules/angular2/src/core/compiler/runtime_metadata.ts
@@ -79,15 +79,15 @@ export class RuntimeMetadataResolver {
             `Unexpected directive value '${stringify(directives[i])}' on the View of component '${stringify(component)}'`);
       }
     }
-    return removeDuplicatedDirectives(directives.map(type => this.getMetadata(type)));
+
+    return removeDuplicates(directives).map(type => this.getMetadata(type));
   }
 }
 
-function removeDuplicatedDirectives(directives: cpl.CompileDirectiveMetadata[]):
-    cpl.CompileDirectiveMetadata[] {
-  var directivesMap = new Map<Type, cpl.CompileDirectiveMetadata>();
-  directives.forEach((dirMeta) => { directivesMap.set(dirMeta.type.runtime, dirMeta); });
-  return MapWrapper.values(directivesMap);
+function removeDuplicates(items: any[]): any[] {
+  let m = new Map<any, any>();
+  items.forEach(i => m.set(i, null));
+  return MapWrapper.keys(m);
 }
 
 function flattenDirectives(view: ViewMetadata): Type[] {

Original file line number	Diff line number	Diff line change
`@@ -79,15 +79,15 @@ export class RuntimeMetadataResolver {`
`79`	`79`	`Unexpected directive value '${stringify(directives[i])}' on the View of component '${stringify(component)}'`);
`80`	`80`	`}`
`81`	`81`	`}`
`82`		`- return removeDuplicatedDirectives(directives.map(type => this.getMetadata(type)));`
	`82`	`+`
	`83`	`+ return removeDuplicates(directives).map(type => this.getMetadata(type));`
`83`	`84`	`}`
`84`	`85`	`}`
`85`	`86`
`86`		`-function removeDuplicatedDirectives(directives: cpl.CompileDirectiveMetadata[]):`
`87`		`- cpl.CompileDirectiveMetadata[] {`
`88`		`- var directivesMap = new Map<Type, cpl.CompileDirectiveMetadata>();`
`89`		`- directives.forEach((dirMeta) => { directivesMap.set(dirMeta.type.runtime, dirMeta); });`
`90`		`- return MapWrapper.values(directivesMap);`
	`87`	`+function removeDuplicates(items: any[]): any[] {`
	`88`	`+ let m = new Map<any, any>();`
	`89`	`+ items.forEach(i => m.set(i, null));`
	`90`	`+ return MapWrapper.keys(m);`
`91`	`91`	`}`
`92`	`92`
`93`	`93`	`function flattenDirectives(view: ViewMetadata): Type[] {`