X Tutup
Skip to content

Commit 2c8fcec

Browse files
vsavkinvsavkin
committed
refactor(core): move render/dom from core
Currently, core depends on DomRenderer, which depends on the browser. This means that if you depend on angular2/core, you will always pull in the browser dom adapter and the browser render, regardless if you need them or not. This PR moves the browser dom adapter and the browser renderer out of core. BREAKING CHANGE If you import browser adapter or dom renderer directly (not via angular2/core), you will have to change the import path.
1 parent 60a2bbb commit 2c8fcec

File tree

120 files changed

+1163
-806
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

120 files changed

+1163
-806
lines changed

‎modules/angular2/angular2.dart‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,5 @@ export 'package:angular2/profile.dart';
1212
export 'package:angular2/lifecycle_hooks.dart';
1313
export 'package:angular2/src/core/application_tokens.dart'
1414
hide APP_COMPONENT_REF_PROMISE, APP_ID_RANDOM_PROVIDER;
15-
export 'package:angular2/src/core/render/dom/dom_tokens.dart';
15+
export 'package:angular2/src/platform/dom/dom_tokens.dart';
16+
export 'package:angular2/compiler.dart' show UrlResolver, AppRootUrl;

‎modules/angular2/angular2.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,4 @@ export * from './profile';
44
export * from './lifecycle_hooks';
55
export * from './platform/browser';
66
export * from './upgrade';
7+
export {UrlResolver, AppRootUrl} from './compiler';

‎modules/angular2/compiler.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,5 @@
55
*/
66
export * from './src/compiler/url_resolver';
77
export * from './src/compiler/xhr';
8-
export * from './src/compiler/compiler';
8+
export * from './src/compiler/compiler';
9+
export * from './src/compiler/app_root_url';

‎modules/angular2/core.dart‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,16 @@ export 'package:angular2/src/common/pipes.dart';
99
export 'package:angular2/src/facade/facade.dart';
1010
export 'package:angular2/src/core/application_ref.dart'
1111
hide ApplicationRef_, PlatformRef_;
12-
export 'package:angular2/src/core/services.dart';
1312
export 'package:angular2/src/core/linker.dart';
1413
export 'package:angular2/src/core/zone.dart';
1514
export 'package:angular2/src/core/render.dart';
1615
export 'package:angular2/src/common/directives.dart';
1716
export 'package:angular2/src/common/forms.dart';
18-
export 'package:angular2/src/core/debug.dart';
17+
export 'package:angular2/src/core/debug/debug_element.dart' show DebugElement, Scope, inspectElement, asNativeElements;
18+
export 'package:angular2/src/core/testability/testability.dart';
1919
export 'package:angular2/src/core/change_detection.dart';
2020
export 'package:angular2/src/core/platform_directives_and_pipes.dart';
2121
export 'package:angular2/src/core/platform_common_providers.dart';
2222
export 'package:angular2/src/core/application_common_providers.dart';
2323
export 'package:angular2/src/core/reflection/reflection.dart';
24+
export 'package:angular2/src/core/dom/dom_adapter.dart';

‎modules/angular2/core.ts‎

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,24 @@ export * from './src/core/util';
88
export * from './src/core/di';
99
export * from './src/common/pipes';
1010
export * from './src/facade/facade';
11-
export * from './src/core/services';
1211
export * from './src/core/linker';
1312
export {platform, createNgZone, PlatformRef, ApplicationRef} from './src/core/application_ref';
1413
export {APP_ID, APP_COMPONENT} from './src/core/application_tokens';
1514
export * from './src/core/zone';
1615
export * from './src/core/render';
1716
export * from './src/common/directives';
1817
export * from './src/common/forms';
19-
export * from './src/core/debug';
18+
export {
19+
DebugElement,
20+
Scope,
21+
inspectElement,
22+
asNativeElements
23+
} from './src/core/debug/debug_element';
24+
export * from './src/core/testability/testability';
2025
export * from './src/core/change_detection';
2126
export * from './src/core/platform_directives_and_pipes';
2227
export * from './src/core/dev_mode';
2328
export * from './src/core/reflection/reflection';
2429
export * from './src/core/application_common_providers';
2530
export * from './src/core/platform_common_providers';
31+
export * from './src/core/dom/dom_adapter';

‎modules/angular2/platform/browser.ts‎

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,13 @@
1-
export {BROWSER_PROVIDERS} from 'angular2/src/platform/browser_common';
1+
export {
2+
BROWSER_PROVIDERS,
3+
ELEMENT_PROBE_BINDINGS,
4+
ELEMENT_PROBE_PROVIDERS,
5+
inspectNativeElement,
6+
BrowserDomAdapter,
7+
By,
8+
Title,
9+
DOCUMENT
10+
} from 'angular2/src/platform/browser_common';
211

312
import {Type, isPresent, CONST_EXPR} from 'angular2/src/facade/lang';
413
import {Promise} from 'angular2/src/facade/promise';

‎modules/angular2/platform/browser_static.ts‎

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,12 @@
1-
export {BROWSER_PROVIDERS} from 'angular2/src/platform/browser_common';
1+
export {
2+
BROWSER_PROVIDERS,
3+
ELEMENT_PROBE_BINDINGS,
4+
ELEMENT_PROBE_PROVIDERS,
5+
inspectNativeElement,
6+
BrowserDomAdapter,
7+
By,
8+
Title
9+
} from 'angular2/src/platform/browser_common';
210

311
import {Type, isPresent, CONST_EXPR} from 'angular2/src/facade/lang';
412
import {Promise} from 'angular2/src/facade/promise';

‎modules/angular2/platform/common_dom.ts‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
/**
2+
* This is a set of classes and objects that can be used both in the browser and on the server.
3+
*/
4+
export {DomRenderer} from 'angular2/src/platform/dom/dom_renderer';
5+
export {DOCUMENT} from 'angular2/src/platform/dom/dom_tokens';
6+
export {SharedStylesHost, DomSharedStylesHost} from 'angular2/src/platform/dom/shared_styles_host';
7+
export {DomEventsPlugin} from 'angular2/src/platform/dom/events/dom_events';

‎modules/angular2/platform/server.dart‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
// TODO: vsavkin add SERVER_PROVIDERS and SERVER_APP_PROVIDERS
2+
export 'package:angular2/src/platform/server/html_adapter.dart';

‎modules/angular2/platform/server.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
// TODO: vsavkin add SERVER_PROVIDERS and SERVER_APP_PROVIDERS
2+
export {Parse5DomAdapter} from 'angular2/src/platform/server/parse5_adapter';

0 commit comments

Comments
 (0)
X Tutup