X Tutup
Skip to content

Commit 039b7e7

Browse files
committed
WIP: testing
1 parent 78428d9 commit 039b7e7

File tree

6 files changed

+12
-8
lines changed

6 files changed

+12
-8
lines changed

karma-js.conf.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ module.exports = function(config) {
1111
files: [
1212
// Sources and specs.
1313
// Loaded through the System loader, in `test-main.js`.
14-
{pattern: 'dist/@angular/**/*.js', included: false, watched: false},
14+
{pattern: 'dist/@angular/**/*.js', included: false, watched: true},
15+
{pattern: 'dist/@angular/**/*.js.map', included: false, watched: false},
1516

1617
'node_modules/es6-shim/es6-shim.js',
1718
// include Angular v1 for upgrade module testing
@@ -30,7 +31,8 @@ module.exports = function(config) {
3031
'node_modules/reflect-metadata/Reflect.js',
3132
'tools/build/file2modulename.js',
3233
'test-main.js',
33-
{pattern: 'modules/@angular/testing/test/static_assets/**', included: false, watched: false}
34+
{pattern: 'modules/@angular/testing/test/static_assets/**', included: false, watched: false},
35+
{pattern: 'modules/@angular/platform-browser/static_assets/**', included: false, watched: false}
3436
],
3537

3638
exclude: ['dist/@angular/**/e2e_test/**', 'dist/@angular/examples/**', 'dist/angular1_router.js', 'dist/@angular/testing/src/e2e_util.js'],

modules/@angular/platform-browser-dynamic/platform_browser_dynamic.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {isPresent} from '@angular/facade';
55
import {XHRImpl} from './src/xhr/xhr_impl';
66
import {BROWSER_APP_COMMON_PROVIDERS, browserPlatform} from '@angular/platform-browser';
77
import {reflector, ReflectiveInjector, coreLoadAndBootstrap} from '@angular/core';
8-
import {DOM} from './platform_browser_private';
8+
import {getDOM} from './platform_browser_private';
99
import {ReflectionCapabilities} from './core_private';
1010

1111
export const CACHED_TEMPLATE_PROVIDER: Array<any /*Type | Provider | any[]*/> =
@@ -92,7 +92,7 @@ export const BROWSER_APP_PROVIDERS: Array<any /*Type | Provider | any[]*/> = /*@
9292
export function bootstrap(
9393
appComponentType: Type,
9494
customProviders?: Array<any /*Type | Provider | any[]*/>): Promise<ComponentRef> {
95-
DOM.xhrType = XHRImpl;
95+
getDOM().xhrType = XHRImpl;
9696
reflector.reflectionCapabilities = new ReflectionCapabilities();
9797
var appInjector = ReflectiveInjector.resolveAndCreate(
9898
[BROWSER_APP_PROVIDERS, isPresent(customProviders) ? customProviders : []],
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
import {__platform_browser_private__ as _} from '@angular/platform-browser';
22

33
export type DomAdapter = _.DomAdapter;
4-
export var DOM: _.DomAdapter = _.DOM;
4+
export function getDOM(): _.DomAdapter { return _.getDOM() };

modules/@angular/platform-browser-dynamic/test/xhr/xhr_impl_spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ export function main() {
2424
// static_assets/200.html.
2525
// We currently have no way of detecting this.
2626
var urlBase = IS_DART ? '' : '/base/modules/@angular/';
27-
var url200 = urlBase + 'platform-browser/static_assets/200.html';
27+
var url200 = urlBase + 'platform-browser-dynamic/static_assets/200.html';
2828
var url404 = '/bad/path/404.html';
2929

3030
beforeEach(() => { xhr = new XHRImpl(); });

modules/@angular/testing/browser.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import {
22
TEST_BROWSER_STATIC_PLATFORM_PROVIDERS,
33
ADDITIONAL_TEST_BROWSER_PROVIDERS
44
} from './browser_static';
5-
import {BROWSER_APP_PROVIDERS} from '@angular/platform-browser';
5+
import {BROWSER_APP_PROVIDERS} from '@angular/platform-browser-dynamic';
66

77

88
/**

test-main.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,9 @@ System.config({
4040
'@angular/platform-browser': {
4141
main: 'index'
4242
},
43+
'@angular/platform-browser-dynamic': {
44+
main: 'index'
45+
},
4346
// '@angular/platform-browser/testing': {
4447
// main: 'index'
4548
// }
@@ -71,7 +74,6 @@ System.import('@angular/testing').then(function(testing) {
7174
.then(function() {
7275
__karma__.start();
7376
}, function(error) {
74-
console.log(error)
7577
__karma__.error(error.stack || error);
7678
});
7779

0 commit comments

Comments
 (0)
X Tutup