X Tutup
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: IcodeNet/angular-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: IcodeNet/angular-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: filipesilva-patch-1
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Aug 30, 2017

  1. fix(@angular/cli): remove bootstrap dirname 

    The dirname check is causing problems when using WSL (Bash on Windows), due to the dirname being adapted to the WSL paths.

This causes the bootstrap to not correctly replace the local lib requests, which in turn causes `@ngtools/webpack` to not be able to detect the correct instance of `AoTPlugin` which leads to `Module build failed: TypeError: Cannot read property 'newLine' of undefined` errors.

It's also extraneous, since whenever we're running `bootstrap-local.ts` we're always in a linked state anyway.

Note: this is not the sole cause of `Module build failed: TypeError: Cannot read property 'newLine' of undefined` errors, they are generally due to multiple installed versions of `@ngtools/webpack` (which can be seen with `npm ls @ngtools/webpack`).
    @filipesilva
    filipesilva committed Aug 30, 2017
    Configuration menu
    Copy the full SHA
    7e17acb View commit details
    Browse the repository at this point in the history
Loading
X Tutup