Fix 2 bugs with Language Standard Feature#1317
Open
MAJigsaw77 wants to merge 2 commits intoHaxeFoundation:masterfrom
Open
Fix 2 bugs with Language Standard Feature#1317MAJigsaw77 wants to merge 2 commits intoHaxeFoundation:masterfrom
MAJigsaw77 wants to merge 2 commits intoHaxeFoundation:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HXCPP_CPP17inside aBuild.xmlbut in the latest commit we cannot unless we define it inside the command, this behaviour is now fixed by moving the check insidecreateFileGroup, it allows the xml to be parsed first and then thesetfor theHXCPP_CPP17would work just fine.fileselement doesnt work as expected, if theres asectionelement inside thefileselement it, in that section the language standard that has been set my the parent will be forgotten, this behaviour is now fixed and allows sections to have the language standard work properly.