X Tutup
Skip to content

Add missing win32 semaphore free zone exit call#1316

Merged
Simn merged 2 commits intoHaxeFoundation:masterfrom
Aidan63:missing-semaphore-zone-exit
Mar 8, 2026
Merged

Add missing win32 semaphore free zone exit call#1316
Simn merged 2 commits intoHaxeFoundation:masterfrom
Aidan63:missing-semaphore-zone-exit

Conversation

@Aidan63
Copy link
Contributor

@Aidan63 Aidan63 commented Mar 8, 2026

I should look into having something like AutoGCFreeZone which supports hx::Throw, it's too easy to miss calls doing it manually.

@Simn
Copy link
Member

Simn commented Mar 8, 2026

Note that I'm seeing these semaphore failures on linux, e.g. here: https://github.com/HaxeFoundation/haxe/actions/runs/22828051610/job/66211778030?pr=12752

@Aidan63
Copy link
Contributor Author

Aidan63 commented Mar 8, 2026

I assumed sem_timedwait would return actual error codes, but no, on failure it returns -1 and you then need to check errno... posix is awful.

@Simn Simn merged commit 3160951 into HaxeFoundation:master Mar 8, 2026
265 of 266 checks passed
@Aidan63 Aidan63 deleted the missing-semaphore-zone-exit branch March 8, 2026 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup