Macro generated EVars position fixes#11163
Merged
Simn merged 5 commits intoHaxeFoundation:developmentfrom Apr 27, 2023
Merged
Conversation
kLabz
changed the title
kLabz
added a commit
that referenced
this pull request
May 9, 2023
* set EVars position from macro reification * [tests] add test for 11162 * Expose Var.namePos * Fallback to EVars position for var names when namePos is null_pos * fix null_pos check
13 tasks
This was referenced May 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #11162
I'd add that to 4.3_bugfix but that might be a problematic change because of
Var.namePosaddition?