[cppia] Generate scriptable functions for overriden functions#11773
Merged
Simn merged 1 commit intoHaxeFoundation:developmentfrom Sep 17, 2024
Merged
[cppia] Generate scriptable functions for overriden functions#11773Simn merged 1 commit intoHaxeFoundation:developmentfrom
Simn merged 1 commit intoHaxeFoundation:developmentfrom
Conversation
Member
|
Does this interact with overloads somehow given that we're comparing methods by name? |
Contributor
Author
|
I don't think so. Overloads only really work on extern classes iirc, and that code is only ran on haxe classes and interfaces. |
|
This fix doesn't seem to have released a new haxe yet. Can I get a new haxe executable file from the nightly build? Which one is stable? (Mac user) |
|
4.3 bug fix did not update this modification. Can it be fixed in 4.3? |
src/haxe/ds/_GenericStack/GenericStackIterator_hscript_Token.cpp
Error: ./src/haxe/ds/_GenericStack/GenericStackIterator_hscript_Token.cpp:141:13: error: invalid covariant return type for 'virtual Dynamic haxe::ds::_GenericStack::GenericStackIterator_hscript_Token_obj__scriptable::next()'
::Dynamic next( ) {
^
./src/haxe/ds/_GenericStack/GenericStackIterator_hscript_Token.cpp:48:19: error: overriding 'virtual hscript::Token haxe::ds::_GenericStack::GenericStackIterator_hscript_Token_obj::next()'
::hscript::Token GenericStackIterator_hscript_Token_obj::next(){
^
./src/haxe/ds/_GenericStack/GenericStackIterator_hscript_Token.cpp:152:55: warning: 'fastcall' attribute directive ignored [-Wattributes]
static void CPPIA_CALL __s_hasNext(::hx::CppiaCtx *ctx) {
^
./src/haxe/ds/_GenericStack/GenericStackIterator_hscript_Token.cpp:157:52: warning: 'fastcall' attribute directive ignored [-Wattributes]
static void CPPIA_CALL __s_next(::hx::CppiaCtx *ctx) {
^
./src/haxe/ds/_GenericStack/GenericStackIterator_hscript_Token.cpp:171:67: warning: 'fastcall' attribute directive ignored [-Wattributes]
static void CPPIA_CALL __script_construct_func(::hx::CppiaCtx *ctx) {I have tried this fix, but compilation errors occur. |
|
Even with this PR, the test cases cannot pass. This is my issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes HaxeFoundation/hxcpp#1150
Test has been added in this hxcpp merge HaxeFoundation/hxcpp#1154
That hxcpp merge is failing due to the new test, once this is merged the CI on that hxcpp merge should be re-ran and it will then pass.