Fixed hbytes compare#11610
Fixed hbytes compare#11610onehundredfeet wants to merge 108 commits intoHaxeFoundation:developmentfrom
Conversation
* [pcre] Fix bytecode bindings issues * [pcre] Fix another argument type * Fix one more bytecode stub * Fix minor typo
* Add white space around template type syntax * removed trailing whitespace after comma in type parameter list
* Message reporting: namespace defines * [tests] update message reporting defines * [tests] update message reporting define for unit tests * also rename no-color define internally * update message reporting defines in get_signature
* Do not raise final assign in display * handle `finalField|` hover case * handle `finalField = value|` hover
…n#11192) * [tests] add test for HaxeFoundation#11005 * Allow non constant values for inline variable init if -D no-inline * [typer] use ctx.doinline instead of -D no-inline * [tests] update test for 11005
* set EVars position from macro reification * [tests] add test for 11162 * Expose Var.namePos * Fallback to EVars position for var names when namePos is null_pos * fix null_pos check
|
@yuxiaomao Could you confirm that this is good, and while we're here also add the |
|
Both changes seems good to me. Should I add the Note: HLC test code var pipes = new hl.NativeArray(1);
trace(pipes == null); // false
var bytes = new hl.Bytes(0);
trace(bytes == null); // true
var bytes = new hl.Bytes(1);
trace(bytes == null); // false |
|
Uh, this branch doesn't seem to like |
|
I don't know what's happening here, it didn't look like this when I saw this yesterday... in that case it's probably easier if we commit these two changes (for both bytes and array) directly. |
|
Please also add the |
|
Should we close #11468 ? |
|
Ideally we add a test first. |
10 participants
Fixed a missing case for comparison in HL/C generation. HBytes, when compared with null (or other HBytes) were falling through the comparison case and resulting in a 'Don't know how to compare error'.
Just added them in with a physical comparison which results in a C == comparison.