Update __init__ to deal with outdated pkg_resources package for newer versions of python#82
Merged
freedomofkeima merged 2 commits intoHDE:masterfrom Jul 16, 2024
Merged
Conversation
freedomofkeima
approved these changes
Jul 16, 2024
Collaborator
freedomofkeima
left a comment
freedomofkeima
left a comment
There was a problem hiding this comment.
@WouterDurnez Hi, thanks for the contribution! 👋
This package hasn't been maintained in years, but I confirmed your fix works fine in my machine. Let me merge this to the main branch 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 👋
Not sure if this is still maintained, but wondering if anyone could look at this.
pkg_resources, which is imported in the init to get the__version__, is deprecated. Usingimportlibwould solve the issue, I believe. That would make the package compatible with newer versions of python (3.12 and up).Ran the tests, all green (but not sure how thorough they are).
Thanks!