Merged
Conversation
Pharo3-4-5: #defaultValue should not be called from within #use:during:
Switch build status to SVG so it's not blurry on high res displays.
Switch build status to SVG
…orrectly implement expected semantics (see method comments for details)
Fixes for GRDynamicVariable in GemStone
(so I learn that github not automatically pushes back to the branch of the PR when you resolve changes in its webeditor, but also changes from the merge are pushed back!!!!)
Member
Author
|
@dalehenrich speaking of Grease ;) Do you think this one can be merged? |
Member
|
What about the test failures for Squeak5.1? are those expected errors? |
Member
Author
|
(now doing this from github, so pretty sure it's the right thread.... ) Yes, these are Slime tests that started failing some weeks ago without changes in Grease itself. So, I propose to ignore them here. |
Member
|
see this comment where @jbrichau gives his blessing to ignored the Squeak5.1 failures ... |
Member
|
@jbrichau you might consider moving Squeak5.1 into expected failures for travis so that we can record that Squeak5.1 is not expected to pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grease 1.3.2 fixes bugs in the implementation of GRDynamicVariable in GemStone.
If we can have this one used in GsDevKit/GLASS, then at least the tests for Seaside develop will work again in GemStone.