X Tutup
Skip to content

Sync with SeasideSt/Grease master repo#31

Merged
dalehenrich merged 52 commits intomasterfrom
merge
Feb 6, 2024
Merged

Sync with SeasideSt/Grease master repo#31
dalehenrich merged 52 commits intomasterfrom
merge

Conversation

@jbrichau
Copy link
Member

@jbrichau jbrichau commented Feb 4, 2024

See for changes in 1.16.0: https://github.com/SeasideSt/Grease/releases/tag/v1.16.0

For GemStone, we added the implementation that support temporary file creation to be able to also port the streaming file uploads in Seaside to GemStone

All other changes are about the Smile code style rules which only work in Pharo.

(Recreated this PR in a branch to make the CI action that uses the Slack secret to run)

Johan Brichau added 30 commits September 11, 2023 18:59
GREmptyStatementRule is superseded in Pharo by ReMultiplePeriodsTermi…
eef7478 
…natingStatementRule
Literal byte arrays are accepted in Pharo, GemStone and VAST
8bd356e
Merge branch 'master' into slime-renovation
b6ee952
First couple of Slime rules and tests converted to Reraku critiques
1a385fc
Correct baseline typo
98f2c5c
Remove obsolete tests from older Slime test package as well
171232f
Fix another baseline typo
d6705ff
ported rules: invalid object initialization and non-portable messages
81bec5c
Ported Slime rule for referencing/using a non-portable class
2800c45
Block and Parens formatting rules moved to the PharoWithStyle project…
1c02177 
…; removed the curly braces rule since it is not applicable anymore
Moved the return and temps formatting rules to the PharoWithStyle pro…
18a37b0 
…ject
Two more Slime rules ported
e34bcc2
Ported ANSI Booleans transformation Slime rule
002bf2e
fix
1ec525d
Ported all transformation Slime rules
59552a5
Change class names back to previous class names (i.e. 'GRReXXX' to 'G…
1031a70 
…RXXX')
Fix ANSI characters Slime rule
bfea7ea
Fix ANSIStrings Slime rule
4990652
test with smalltalkCI fork for Pharo12 fix
8f6c9b8
try again to run against smalltalk-CI branch
52ba234
try new fix branch for SmalltalkCI
4e5cec2
Merge pull request SeasideSt#167 from SeasideSt/slime-renovation
59b1042 
Slime renovation
Fixes Slime test for empty statements (will work correctly after fix …
64ac15d 
…for issue pharo-project/pharo#15955 is merged into Pharo)
Add Pharo110 to GRPackage resolution
c4074b0
fix resolveWith: older version package names are used in later Pharo …
55f34f4 
…versions
gemstone 3.6.7 is no longer available for download, switching back to…
9aac9aa 
… testing with 3.6.6
Merge branch 'master' into fix-testEmptyStatements
5eb55c9
Mark testEmptyStatements as fixed in Pharo 12 but breaking in earlier…
b073206 
… versions
Merge 5eb55c9
d8f5204
Merge pull request SeasideSt#168 from SeasideSt/fix-testEmptyStatements
c53e80a 
Fixes Slime test for empty statements (will work correctly after fix …
Johan Brichau added 22 commits January 28, 2024 10:34
Fix GRAnsiCharacterRule: should only match character literals
933bc73
Added support for newTemporaryFileReference in GemStone versions high…
788fa15 
…er than 3.3
Deprecate existing newTemporaryFileReference in favour of `newTempo…
4d9ea9f 
…raryFile` which returns a pathString consistent with other Grease file-handling methods
added temporary file creation methods to older Pharo versions
0176ed2
added new temporary file creation methods to GemStone
c83bb49
moved method to GemStone-Core package and implemented missing deleteF…
acf5760 
…ile: method
added file methods for Squeak 6
602230d
Also add temporary file creation methods to Squeak 5
454b8de
added deleteFile: to Squeak
34bd7c3
fix missing method in Squeak 6
f7d355f
Test unique name of two generated temporary files
f20c01f
Fix writeFileStreamOn:do:binary: in Squeak
e628eef
Refactor test for write:toFile:inFolder:
17da932
Merge e628eef
22b0950
throw error when creating a duplicate temporary file
2816e8e
error when creating a duplicate temporary file name on GemStone, olde…
e1a14c9 
…r Pharo and Squeak
use GRPlatform current pathSeparator in the filename generation for t…
14e6afb 
…emporary files on gemstone
revert changes for categories in Squeak packages
5ae43f8
Merge pull request SeasideSt#169 from SeasideSt/temporaryfiles-gemstone
1a66633 
Change temporary file creation api
version 1.16
9b35324
revert using special branch of SmalltalkCI
ee685e4
Merge pull request #30 from SeasideSt/master
58f6c57 
Sync with SeasideSt/Grease master repo
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2024

Codecov Report

Attention: 124 lines in your changes are missing coverage. Please review.

Comparison is base (87912b5) 84.75% compared to head (58f6c57) 85.15%.

Files Patch % Lines
...RTestAssertionsRule.class/instance/checkMethod..st 0.00% 7 Missing ⚠️
....package/GRReSlimeTest.class/instance/canParse..st 0.00% 7 Missing ⚠️
...package/GRAnsiBooleansRule.class/instance/group.st 0.00% 4 Missing ⚠️
...ckage/GRAnsiCharactersRule.class/instance/group.st 0.00% 4 Missing ⚠️
...kage/GRAnsiCollectionsRule.class/instance/group.st 0.00% 4 Missing ⚠️
...age/GRAnsiConditionalsRule.class/instance/group.st 0.00% 4 Missing ⚠️
...ackage/GRAnsiConvertorRule.class/instance/group.st 0.00% 4 Missing ⚠️
...ckage/GRAnsiExceptionsRule.class/instance/group.st 0.00% 4 Missing ⚠️
....package/GRAnsiStreamsRule.class/instance/group.st 0.00% 4 Missing ⚠️
....package/GRAnsiStringsRule.class/instance/group.st 0.00% 4 Missing ⚠️
... and 21 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   84.75%   85.15%   +0.39%     
==========================================
  Files        1923     2051     +128     
  Lines       13092    14115    +1023     
==========================================
+ Hits        11096    12019     +923     
- Misses       1996     2096     +100

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbrichau jbrichau requested a review from dalehenrich February 4, 2024 14:46
@jbrichau
Copy link
Member Author

jbrichau commented Feb 6, 2024

@dalehenrich Any objections in this PR? The packages affecting GemStone are limited and they are additions.
Would be great to be able to continue developing streaming requests for Seaside in Zinc on GemStone as well ;-)

@dalehenrich dalehenrich merged commit 042a0a0 into master Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalehenrich dalehenrich Awaiting requested review from dalehenrich

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jbrichau @codecov-commenter @dalehenrich
X Tutup