X Tutup
Skip to content

sync gsdevkit/Grease from SeasideSt/Grease #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dalehenrich merged 16 commits into from
Nov 5, 2023
Merged

sync gsdevkit/Grease from SeasideSt/Grease #28

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
88459fa
Add #greaseAsByteArray and implementation for Squeak
theseion Oct 29, 2023
f2de993
Add #greaseAsByteArray implementation for Pharo
theseion Oct 29, 2023
eac187b
Add #greaseByteAt: and #greaseBytesCound implementations for Pharo
theseion Oct 29, 2023
1e6b653
Add #greaseByteAt: and #greaseBytesCound implementations for Pharo 7
theseion Oct 29, 2023
65bc55e
Add #greaseByteAt: and #greaseBytesCound implementations for Pharo 6
theseion Oct 29, 2023
f67408f
Improve tests for #greaseAsByteArray, #greaseByteAt:, #greaseByteCounts
theseion Oct 29, 2023
845a2c1
Fix implementation of #greaseByteAt:, #greaseBytesCount in Pharo 7
theseion Oct 29, 2023
7049682
Fix implementation of #greaseByteAt:, #greaseBytesCount in Pharo 6
theseion Oct 29, 2023
b9ae2e0
Fix #greaseByteAt: for Squeak
theseion Oct 29, 2023
c7c9826
Add implementation of #greaseAsByteArray for Squeak 5
theseion Oct 29, 2023
b13fba9
Add implementation of #greaseAsByteArray for Squeak 6
theseion Oct 29, 2023
9f6bc41
LargeInteger does not exist in Squeak
theseion Oct 29, 2023
8963e58
LargeInteger does not exist in Squeak
theseion Oct 29, 2023
4c66a68
add implementation in GemStone for Integer>>greaseByteAt: and Integer…
Oct 30, 2023
f7d9822
correct typo in method name
Oct 30, 2023
3a4e4bc
Merge pull request #161 from theseion/add-integer-greaseasbytearray
Nov 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix implementation of #greaseByteAt:, #greaseBytesCount in Pharo 7
  • Loading branch information
@theseion
theseion committed Oct 29, 2023
commit 845a2c13d8bcbcb30ff87fcb42195db29d8d7544
7 changes: 6 additions & 1 deletion repository/Grease-Pharo70-Core.package/LargeInteger.extension/instance/greaseByteAt..st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
*Grease-Pharo70-Core
greaseByteAt: index
^ self byteAt: index
"Primitive. Answer the value of an indexable field in the receiver. LargePositiveInteger uses bytes of base two number, and each is a 'digit' base 256. Fail if the argument (the index) is not an Integer or is out of bounds. Essential. See Object documentation whatIsAPrimitive."

<primitive: 60>
self greaseBytesCount < index
ifTrue: [^0]
ifFalse: [^super at: index]
7 changes: 6 additions & 1 deletion repository/Grease-Pharo70-Core.package/LargeInteger.extension/instance/greaseBytesCount.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
*Grease-Pharo70-Core
greaseBytesCount
^ self bytesCount
"Primitive. Answer the number of indexable fields in the receiver. This
value is the same as the largest legal subscript. Essential. See Object
documentation whatIsAPrimitive."

<primitive: 62>
self primitiveFailed
15 changes: 13 additions & 2 deletions repository/Grease-Pharo70-Core.package/SmallInteger.extension/instance/greaseByteAt..st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,14 @@
*Grease-Pharo70-Core
greaseByteAt: index
^ self byteAt: index
greaseByteAt: n
"Answer the value of an apparent byte-indexable field in the receiver,
analogous to the large integers, which are organized as bytes."

n = 1
ifTrue: [
"Negate carefully in case the receiver is SmallInteger minVal"
^ self < 0
ifTrue: [ -256 - self bitAnd: 255 ]
ifFalse: [ self bitAnd: 255 ] ].
^ self < 0
ifTrue: [ (-256 - self bitShift: -8) + 1 byteAt: n - 1 ]
ifFalse: [ (self bitShift: 8 - (n bitShift: 3)) bitAnd: 255 ]
24 changes: 23 additions & 1 deletion repository/Grease-Pharo70-Core.package/SmallInteger.extension/instance/greaseBytesCount.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,25 @@
*Grease-Pharo70-Core
greaseBytesCount
^ self bytesCount
"Answer the number of indexable fields in the receiver. This value is the
same as the largest legal subscript. Included so that a SmallInteger can
behave like a LargePositiveInteger or LargeNegativeInteger."

"32768 == (1 bitShift: 15)"
"32768 bytesCount >>> 2"

"65536 == (1 bitShift: 16)"
"65536 bytesCount >>> 3"

| value length |
length := 1.
value := self.
value >= 0
ifTrue:
[[value > 255] whileTrue:
[value := value bitShift: -8.
length := length + 1]]
ifFalse:
[[value < -255] whileTrue:
[value := value bitShift: -8.
length := length + 1]].
^length
X Tutup