Conversation
Rename package Pharo10 to Pharo100 to avoid confusion with Pharo1
…fix svenvc/zinc#86 is part of the released version
fix grpackage methods for pharo100 (useless?)
…ll Squeak builds to the experimental part (help wanted maintaining Squeak!)
Move all codecs in Pharo10 to use Zinc
…latform and concrete implementations to GRPharoPlatform and GRSqueakPlatform
#writeFileStreamOn:do:binary: already provides this functionality
#writeFileStreamOn:do:binary: already provides this functionality
#writeFileStreamOn:do:binary: already provides this functionality
#writeFileStreamOn:do:binary: already provides this functionality
…loads File utilities for streaming uploads
* moved the methods dealing with files into their own protocol (they were in the 'file library' protocol which is specific support for Seaside file libraries) * added GRPlatforn>>deleteFile:, GRDelegatingStream>>position:, GRPlatform>>newTemporaryFileReferenceNamed:
|
@jbrichau, looks like only the pharo tests are failing .... are they important? Perhaps they should be removed, so green means green ... |
|
@dalehenrich I think the build is coloring red because of the failing 'post to slack' step. The Pharo 11 and Squeak builds are marked as experimental. The build is green over at SeasideSt: https://github.com/SeasideSt/Grease/actions/runs/2724711470 Perhaps something changed in the Slack integration? |
|
ah, so those guys are expected failures? I'm seeing the messages in slack (so the error must not be a "real error"? .. I wouldn't see the messages in slack if there was an invalid webhook id ... I even am getting two copies of the slack messages --- but in slack that they've decided to ignore that bug) ... It's not as easy with guthub actions to see immediately see that an action is an expected failure ... If they are expected failures then the red boys can be ignored ... |
|
Okay it looks like Pharo64-11 is NOT marked as experimental ... Pharo64-10 IS experimental (line 22 and 23) ... so that's why the action is failing... could you make the change on your pull request? I think that's easier for you to do ... |
|
@dalehenrich I'm not sure what's causing the confusion. This PR does change it as such: https://github.com/GsDevKit/Grease/pull/25/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03f |
|
Okay ... then I suppose this just might be a github action issue then (using the old version of the .yml to run the new stuff...) ... I'll go ahead and merge the request and try rerunning the tests to see if it works afterwards ... |
|
I'm going blind, I don't see in the diff where Pharo64-11 was added to the |
|
@dalehenrich hold on, I'll get to my laptop and check before you merge to make sure ;-) |
|
I thought it needed to be in the list ... but maybe not ... YAML is not my strong suit :) |
|
Discussed on Slack: it's good to go. |
Update GsDevKit Grease to finalize support for: