X Tutup
Skip to content

Grease v1.10#25

Merged
jbrichau merged 35 commits intoGsDevKit:masterfrom
SeasideSt:master
Aug 1, 2022
Merged

Grease v1.10#25
jbrichau merged 35 commits intoGsDevKit:masterfrom
SeasideSt:master

Conversation

@jbrichau
Copy link
Member

@jbrichau jbrichau commented Aug 1, 2022

Update GsDevKit Grease to finalize support for:

Johan Brichau and others added 30 commits January 24, 2022 20:41
- removed codecs and texts based on TextConverter or LanguageEnvironment (deprecated  in pharo 9)
- changes sends of tempAt: by namedTempAt:
Rename package Pharo10 to Pharo100 to avoid confusion with Pharo1
fix grpackage methods for pharo100 (useless?)
…ll Squeak builds to the experimental part (help wanted maintaining Squeak!)
Move all codecs in Pharo10 to use Zinc
…latform and concrete implementations to GRPharoPlatform and GRSqueakPlatform
#writeFileStreamOn:do:binary: already provides this functionality
#writeFileStreamOn:do:binary: already provides this functionality
#writeFileStreamOn:do:binary: already provides this functionality
 #writeFileStreamOn:do:binary: already provides this functionality
Johan Brichau added 5 commits June 6, 2022 10:42
…loads

File utilities for streaming uploads
* moved the methods dealing with files into their own protocol (they were in the 'file library' protocol which is specific support for Seaside file libraries)
* added GRPlatforn>>deleteFile:, GRDelegatingStream>>position:, GRPlatform>>newTemporaryFileReferenceNamed:
@dalehenrich
Copy link
Member

@jbrichau, looks like only the pharo tests are failing .... are they important? Perhaps they should be removed, so green means green ...

@jbrichau
Copy link
Member Author

jbrichau commented Aug 1, 2022

@dalehenrich I think the build is coloring red because of the failing 'post to slack' step. The Pharo 11 and Squeak builds are marked as experimental. The build is green over at SeasideSt: https://github.com/SeasideSt/Grease/actions/runs/2724711470

Perhaps something changed in the Slack integration?

@dalehenrich
Copy link
Member

dalehenrich commented Aug 1, 2022

ah, so those guys are expected failures? I'm seeing the messages in slack (so the error must not be a "real error"? .. I wouldn't see the messages in slack if there was an invalid webhook id ... I even am getting two copies of the slack messages --- but in slack that they've decided to ignore that bug) ... It's not as easy with guthub actions to see immediately see that an action is an expected failure ...

If they are expected failures then the red boys can be ignored ...

@dalehenrich
Copy link
Member

dalehenrich commented Aug 1, 2022

Okay it looks like Pharo64-11 is NOT marked as experimental ... Pharo64-10 IS experimental (line 22 and 23) ... so that's why the action is failing... could you make the change on your pull request? I think that's easier for you to do ...

@jbrichau
Copy link
Member Author

jbrichau commented Aug 1, 2022

@dalehenrich I'm not sure what's causing the confusion. This PR does change it as such: https://github.com/GsDevKit/Grease/pull/25/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03f

@dalehenrich
Copy link
Member

Okay ... then I suppose this just might be a github action issue then (using the old version of the .yml to run the new stuff...) ... I'll go ahead and merge the request and try rerunning the tests to see if it works afterwards ...

@dalehenrich
Copy link
Member

dalehenrich commented Aug 1, 2022

I'm going blind, I don't see in the diff where Pharo64-11 was added to the smalltalk list?

@jbrichau
Copy link
Member Author

jbrichau commented Aug 1, 2022

@dalehenrich hold on, I'll get to my laptop and check before you merge to make sure ;-)

@dalehenrich
Copy link
Member

I thought it needed to be in the list ... but maybe not ... YAML is not my strong suit :)

@jbrichau jbrichau merged commit 2925fc8 into GsDevKit:master Aug 1, 2022
@jbrichau
Copy link
Member Author

jbrichau commented Aug 1, 2022

Discussed on Slack: it's good to go.
I'll check if I can find a solution to the Slack post step since we prefer real green, of course ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup