straight up comparison between the two reops#17
Conversation
…ster... removing the artefact of that.
… tests package so we execute the tests on all platforms
…otes/seasidest_grease/104/Filestreams
…ey in the filetree format directly because of the package file name convention violation)
…wards instead of a 'file' spec hack (which breaks working in Tode)
…e to solve issues with working with this package in the tode git tools
…k this is really necessary at all. Will need to mention this in the changelog and create a version increase to signal this change of behaviour on Pharo
104/filestreams
…inary-file-are-nil-rather-than-an-empty-instance-of-ByteArray Fix reading contents of empty binary file
…nd make the testLanguageTag make the switch only in Pharo9
Finalize thisContext implementation
Pharo9 utf8 encoding changes
|
@dalehenrich the merge conflict points to differences in the packaging I made here: SeasideSt@9d4fe1a This was done to ease maintenance, since the 'filename' difference was off-putting tools in Tode. I will fix the baseline with that in mind and if you are happy, you can hit the merge button ;-) |
|
Looks like the thisContext test is failing for 2.4.x. I don't think that it is really necessary to support 2.4.x moving forward ... so removing it from the travis lineup would not be a crime :) |
|
Haha, indeed. I will just remove that version from the test lineup. |
|
Haha, and the travis build is still running, but it seems to be passing, so it's looking good ... when travis finishes I will want to manually do a reload from the old version to the new version to see if there are any hiccups (actually I can do this at any time and will when I find the time) ... |
|
... oh, my browser hadn't updated ... rerunning the one test that failed ... |
|
@dalehenrich I added your lineup of gs3.7 to 3.9 to the baseline (future proofness? :-) ). The difference now, besides indentation, is about the last statement: vs This is the change I referred to earlier. Unless you see issues with that, I will just push the baseline of SeasideSt/Grease |
|
I guess, I can't tell quite what you are doing ... Removing the package 'Grease-Tests-GemStone32-Core'? ... If things are working correctly then I suppose it is cool :) |
|
I added it :) |
|
I just did a test load of SeasideSt/Grease:gsdevkit-merge into a 3.6.0 stone with GsDevKit/Grease:master loaded and it loaded without error (yeah!), when I looked at Other than the fact that I thought that you had done the opposite :) I ran the tests and they are all green, so merge away ... |
No description provided.