Docs: Bigtable + Dataflow hello world cleanups#6314
Merged
billyjacobson merged 6 commits intomainfrom Nov 10, 2021
Merged
Conversation
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
samples
# Conflicts: # bigtable/beam/helloworld/pom.xml
kongweihan
reviewed
Oct 27, 2021
|
|
||
| @Description("The Bigtable table ID in the instance.") | ||
| @Default.String("bigtable-table") | ||
| @Default.String("mobile-time-series") |
Contributor
There was a problem hiding this comment.
What's this table? From some example?
Member
Author
There was a problem hiding this comment.
Yeah, it's just the example table. We have a schema for it and use it in a bunch of examples
kolea2
reviewed
Nov 10, 2021
bigtable/beam/helloworld/pom.xml
Outdated
| <maven.compiler.source>1.8</maven.compiler.source> | ||
| <maven.compiler.target>1.8</maven.compiler.target> | ||
| <apache_beam.version>2.31.0</apache_beam.version> | ||
| <!-- Keep this apache_beam.version in sync with version used in bigtable-hbase-beam --> |
Contributor
There was a problem hiding this comment.
Let's add an exclusion to the renovate config so this doesn't accidentally get updated in the future.
kolea2
approved these changes
Nov 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only