X Tutup
Skip to content

docs(compute-samples): updating firewall sample to include target tag#6202

Merged
Sita04 merged 4 commits intomainfrom
firewall-sample-update-tag
Oct 27, 2021
Merged

docs(compute-samples): updating firewall sample to include target tag#6202
Sita04 merged 4 commits intomainfrom
firewall-sample-update-tag

Conversation

@Sita04
Copy link
Copy Markdown
Contributor

@Sita04 Sita04 commented Oct 19, 2021

Fixes #6192

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 19, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 19, 2021
@Sita04 Sita04 requested a review from kurtisvg October 25, 2021 04:45
@Sita04 Sita04 added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Oct 25, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 25, 2021
@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 25, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 25, 2021
@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 25, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 25, 2021
@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2021
@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2021
@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2021
@Sita04 Sita04 merged commit b693d82 into main Oct 27, 2021
@Sita04 Sita04 deleted the firewall-sample-update-tag branch October 27, 2021 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updates to CreateFirewallRule sample

3 participants

X Tutup