Sticky sidebar with native CSS#1309
Open
Every0ne wants to merge 2 commits intoGetSimpleCMS:masterfrom
Open
Conversation
Removal of jQuery libs and methods used to make the admin's panel sidebar sticky in favor of native CSS property. Fixes strange behaviour of sidebar in debug mode.
Textarea, Input and Select fields had no background color defined, which led to dark text on dark background inside fields when using dark Windows/Linux DE themes.
Member
|
Nice, What is the browser support for this? |
Contributor
Author
|
According to this the coverage is pretty good. I can confirm that it works on Android browser and pretty much anything that wasn't left in the woods (IE11), even something as exotic as Otter Browser. Edge supposedly is OK, cannot test as I don't have a copy of Win10 around. The worst that could happen is the sidebar wouldn't stick. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removal of jQuery libs and methods used to make the admin's panel sidebar sticky in favor of native CSS property. Fixes strange behaviour of sidebar in debug mode.