X Tutup
Skip to content

Fix: Preserve ideographic space (U+3000) when trimming XML cell content#712

Merged
appel1 merged 1 commit intoExcelDataReader:developfrom
koshi-yasuda:fix/keep_full_width_space
Jun 28, 2025
Merged

Fix: Preserve ideographic space (U+3000) when trimming XML cell content#712
appel1 merged 1 commit intoExcelDataReader:developfrom
koshi-yasuda:fix/keep_full_width_space

Conversation

@koshi-yasuda
Copy link
Contributor

Hello,

I encountered an issue where ideographic spaces (U+3000, full-width white space) at the beginning and end of cells were being removed during loading.
This occurred because C#'s Trim method removes more characters than those recognized as whitespace in XML (space characters, carriage returns, line feeds, or tabs) when attempting to trim cells without the xml:space="preserve" attribute.

I've resolved this issue by explicitly specifying which characters should be trimmed, in accordance with the XML specification. I would greatly appreciate your review of these changes.

Thank you for your time and consideration.
Best regards

@appel1
Copy link
Collaborator

appel1 commented Jun 28, 2025

Looks good, thanks!

@appel1 appel1 merged commit 04bf596 into ExcelDataReader:develop Jun 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup