Fix: Preserve ideographic space (U+3000) when trimming XML cell content#712
Merged
appel1 merged 1 commit intoExcelDataReader:developfrom Jun 28, 2025
Merged
Conversation
Collaborator
|
Looks good, thanks! |
This was referenced Sep 22, 2025
This was referenced Sep 29, 2025
This was referenced Oct 24, 2025
This was referenced Mar 1, 2026
This was referenced Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I encountered an issue where ideographic spaces (U+3000, full-width white space) at the beginning and end of cells were being removed during loading.
This occurred because C#'s Trim method removes more characters than those recognized as whitespace in XML (space characters, carriage returns, line feeds, or tabs) when attempting to trim cells without the
xml:space="preserve"attribute.I've resolved this issue by explicitly specifying which characters should be trimmed, in accordance with the XML specification. I would greatly appreciate your review of these changes.
Thank you for your time and consideration.
Best regards