Add support for downloading bundles#2
Add support for downloading bundles#2jackwilsdon wants to merge 2 commits intoDragoonAethis:mainfrom
Conversation
574681e to
37011d5
Compare
b272278 to
ce83344
Compare
|
While the job fetching for bundles looks good, there's some stuff I'd like to have handled before declaring support for downloading bundles in the readme, etc:
|
|
|
||
| elif site in ("b", "bundle"): # Bundles | ||
| raise NotImplementedError("itch-dl cannot download bundles yet.") | ||
| bundle_json = get_bundle_json(url_path_parts[1], client) |
There was a problem hiding this comment.
The 2nd URL part does not have to be a bundle ID, it could be download.
| game jam. The input can also be a path to a itch.io JSON file with game jam entries, or just | ||
| a list of itch.io game URLs (not browse/jam pages!) to download. | ||
| The input URL can be any "Browse" page (top, popular, newest, filtered by tags, etc), any | ||
| game jam or any bundle. The input can also be a path to a itch.io JSON file with game jam |
There was a problem hiding this comment.
I'd like some clarification that this does not claim bundles - we'll handle this later.
|
See comments for the changes I'd like to see now, I'll merge it with those and add issues to deal with the remaining stuff later. |
|
@jackwilsdon I'll have some time this weekend for itch-dl, would you like to finish this PR or can I take it as is and fix up what's left? |
|
I don't think I'll have any free time to work on this PR this weekend sorry - feel free to take it 👍 |
No description provided.