X Tutup
Skip to content

[@types/cfn-response]: update types#74602

Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
arturovt:update/cfn-response
Mar 9, 2026
Merged

[@types/cfn-response]: update types#74602
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
arturovt:update/cfn-response

Conversation

@arturovt
Copy link
Contributor

  • Use Record<string, unknown> for responseData to better reflect the key-value shape expected by CloudFormation
  • Add JSDoc comments for all exports and function parameters

Please fill in this template.

@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 27, 2026

@arturovt Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

There aren't any other owners of this package, so a DT maintainer will review it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ A DT maintainer can merge changes when there are no other reviewers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 74602,
  "author": "arturovt",
  "headCommitOid": "33401de6584b8312fdc99f436a2d078ea0907a91",
  "mergeBaseOid": "543c8b0b1e8a8dd99e33b45c6cd17f7dd676895a",
  "lastPushDate": "2026-02-27T22:16:48.000Z",
  "lastActivityDate": "2026-03-09T21:30:55.000Z",
  "mergeOfferDate": "2026-03-09T21:25:02.000Z",
  "mergeRequestDate": "2026-03-09T21:30:55.000Z",
  "mergeRequestUser": "arturovt",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "cfn-response",
      "kind": "edit",
      "files": [
        {
          "path": "types/cfn-response/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/cfn-response/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "arturovt"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "andrewbranch",
      "date": "2026-03-09T21:24:24.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 3975410783,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Author is Owner The author of this PR is a listed owner of the package. No Other Owners This DT module only has one owner, so we can't have someone verify the change. Untested Change This PR does not touch tests labels Feb 27, 2026
@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Feb 27, 2026
@typescript-bot
Copy link
Contributor

Hey @arturovt,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot
Copy link
Contributor

🔔 @arturovt — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in Pull Request Status Board Feb 27, 2026
- Use `Record<string, unknown>` for `responseData` to better reflect
  the key-value shape expected by CloudFormation
- Add JSDoc comments for all exports and function parameters
@arturovt arturovt force-pushed the update/cfn-response branch from b6979af to 33401de Compare March 9, 2026 21:11
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Code Reviews in Pull Request Status Board Mar 9, 2026
@typescript-bot
Copy link
Contributor

@andrewbranch Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in Pull Request Status Board Mar 9, 2026
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Mar 9, 2026
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in Pull Request Status Board Mar 9, 2026
@typescript-bot
Copy link
Contributor

@arturovt: Everything looks good here. I am ready to merge this PR (at 33401de) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@arturovt
Copy link
Contributor Author

arturovt commented Mar 9, 2026

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Mar 9, 2026
@typescript-bot typescript-bot merged commit 6786ff0 into DefinitelyTyped:master Mar 9, 2026
4 checks passed
@arturovt arturovt deleted the update/cfn-response branch March 9, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author is Owner The author of this PR is a listed owner of the package. Maintainer Approved No Other Owners This DT module only has one owner, so we can't have someone verify the change. Self Merge This PR can now be self-merged by the PR author or an owner Untested Change This PR does not touch tests

Projects

Status: Recently Merged

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup