[@types/cfn-response]: update types#74602
[@types/cfn-response]: update types#74602typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
Conversation
|
@arturovt Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PRCode ReviewsThere aren't any other owners of this package, so a DT maintainer will review it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 74602,
"author": "arturovt",
"headCommitOid": "33401de6584b8312fdc99f436a2d078ea0907a91",
"mergeBaseOid": "543c8b0b1e8a8dd99e33b45c6cd17f7dd676895a",
"lastPushDate": "2026-02-27T22:16:48.000Z",
"lastActivityDate": "2026-03-09T21:30:55.000Z",
"mergeOfferDate": "2026-03-09T21:25:02.000Z",
"mergeRequestDate": "2026-03-09T21:30:55.000Z",
"mergeRequestUser": "arturovt",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "cfn-response",
"kind": "edit",
"files": [
{
"path": "types/cfn-response/index.d.ts",
"kind": "definition"
},
{
"path": "types/cfn-response/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"arturovt"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "andrewbranch",
"date": "2026-03-09T21:24:24.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 3975410783,
"ciResult": "pass"
} |
|
Hey @arturovt, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
|
🔔 @arturovt — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
- Use `Record<string, unknown>` for `responseData` to better reflect the key-value shape expected by CloudFormation - Add JSDoc comments for all exports and function parameters
b6979af to
33401de
Compare
|
@andrewbranch Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
@arturovt: Everything looks good here. I am ready to merge this PR (at 33401de) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
|
Ready to merge |
Record<string, unknown>forresponseDatato better reflect the key-value shape expected by CloudFormationPlease fill in this template.
pnpm test <package to test>.