react-native-zeroconf: add published and unpublished events#70693
Conversation
|
@EvanHahn Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 70693,
"author": "EvanHahn",
"headCommitOid": "5582ca3f1bf1423ed08de934d069e5a427aa1df9",
"mergeBaseOid": "f346b3ca468b4936f03745fd37fcff829d5b5f85",
"lastPushDate": "2024-09-26T21:19:00.000Z",
"lastActivityDate": "2024-09-27T12:23:44.000Z",
"mergeOfferDate": "2024-09-27T08:16:00.000Z",
"mergeRequestDate": "2024-09-27T12:23:44.000Z",
"mergeRequestUser": "EvanHahn",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "react-native-zeroconf",
"kind": "edit",
"files": [
{
"path": "types/react-native-zeroconf/index.d.ts",
"kind": "definition"
},
{
"path": "types/react-native-zeroconf/react-native-zeroconf-tests.ts",
"kind": "test"
}
],
"owners": [
"mattapet"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "mattapet",
"date": "2024-09-27T08:15:23.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 2377958253,
"ciResult": "pass"
} |
|
🔔 @mattapet — please review this PR in the next few days. Be sure to explicitly select |
typescript-bot
added
Owner Approved
|
@EvanHahn: Everything looks good here. I am ready to merge this PR (at 5582ca3) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@mattapet: you can do this too.) |
|
Ready to merge |
… and unpublished events by @EvanHahn
3 participants
Please fill in this template.
pnpm test react-native-zeroconf.If changing an existing definition:
published: https://github.com/balthazar/react-native-zeroconf/blob/0e2e1aa037542222c69cacff6dd5fdddd4844659/src/index.js#L85unpublished: https://github.com/balthazar/react-native-zeroconf/blob/0e2e1aa037542222c69cacff6dd5fdddd4844659/src/index.js#L97If this PR brings the type definitions up to date with a new version of the JS library, update the version number in thepackage.json.