Add types for compact-encoding#70443
Merged
typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom Sep 7, 2024
Merged
Conversation
Contributor
|
@EvanHahn Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PR
Code ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 70443,
"author": "EvanHahn",
"headCommitOid": "ac23f7d59ba7e124d296a10222ff4cec7e574cab",
"mergeBaseOid": "218f7c2c4e808ed87b07185e8e04e2dee16dd215",
"lastPushDate": "2024-09-03T21:27:38.000Z",
"lastActivityDate": "2024-09-07T12:27:32.000Z",
"mergeOfferDate": "2024-09-06T20:24:46.000Z",
"mergeRequestDate": "2024-09-07T12:27:32.000Z",
"mergeRequestUser": "EvanHahn",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "compact-encoding",
"kind": "add",
"files": [
{
"path": "types/compact-encoding/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/compact-encoding/compact-encoding-tests.ts",
"kind": "test"
},
{
"path": "types/compact-encoding/index.d.ts",
"kind": "definition"
},
{
"path": "types/compact-encoding/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/compact-encoding/tsconfig.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions.lib.0`)"
}
],
"owners": [],
"addedOwners": [
"EvanHahn"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "andrewbranch",
"date": "2024-09-06T20:24:10.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2327470049,
"ciResult": "pass"
} |
typescript-bot
added
New Definition
Contributor
|
🔔 @EvanHahn — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
EvanHahn
commented
Sep 4, 2024
| "compilerOptions": { | ||
| "module": "node16", | ||
| "lib": [ | ||
| "es2020" |
Contributor
Author
There was a problem hiding this comment.
Needed for the bigint typed arrays, such as BigInt64Array. Let me know if there's a better way to pull those in.
andrewbranch
approved these changes
Sep 6, 2024
typescript-bot
added
Maintainer Approved
Self Merge
Contributor
Contributor
Author
|
Ready to merge |
daelmaak
pushed a commit
to daelmaak/DefinitelyTyped
that referenced
this pull request
Sep 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill in this template.
pnpm test compact-encoding.If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.