Add types for @mapbox/whoots-js#68550
Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom Feb 21, 2024
Merged
Conversation
Contributor
|
@EvanHahn Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 68550,
"author": "EvanHahn",
"headCommitOid": "18b32ed59b9766977f9b9ff524453f94249e1d77",
"mergeBaseOid": "8f7ef473de4df8d14c23e133767fa22ca44431d0",
"lastPushDate": "2024-02-07T22:50:16.000Z",
"lastActivityDate": "2024-02-21T22:01:21.000Z",
"mergeOfferDate": "2024-02-21T21:06:40.000Z",
"mergeRequestDate": "2024-02-21T22:01:21.000Z",
"mergeRequestUser": "EvanHahn",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "mapbox__whoots-js",
"kind": "add",
"files": [
{
"path": "types/mapbox__whoots-js/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/mapbox__whoots-js/index.d.ts",
"kind": "definition"
},
{
"path": "types/mapbox__whoots-js/mapbox__whoots-js-tests.ts",
"kind": "test"
},
{
"path": "types/mapbox__whoots-js/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/mapbox__whoots-js/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"EvanHahn"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2024-02-21T21:05:57.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1933065180,
"ciResult": "pass"
} |
Contributor
|
🔔 @EvanHahn — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
typescript-bot
added
the
Unreviewed
Contributor
|
Re-ping @«anyone?»: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
peterblazejewicz
approved these changes
Feb 21, 2024
Member
peterblazejewicz
left a comment
peterblazejewicz
left a comment
There was a problem hiding this comment.
LGTM!
@EvanHahn thanks!
typescript-bot
added
Maintainer Approved
Self Merge
Contributor
Contributor
Author
|
Ready to merge |
EvanHahn
added a commit
to digidem/mapeo-map-server
that referenced
this pull request
Feb 22, 2024
[@types/mapbox__whoots-js was recently added][0] so we can use it and delete our own types. [0]: DefinitelyTyped/DefinitelyTyped#68550
EvanHahn
added a commit
to digidem/mapeo-map-server
that referenced
this pull request
Feb 22, 2024
[@types/mapbox__whoots-js was recently added][0] so we can use it and delete our own types. [0]: DefinitelyTyped/DefinitelyTyped#68550
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill in this template.
pnpm test @mapbox/whoots-js.Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationIf not, do not conflict with the name of an npm package.dts-gen --dt, not by basing it on an existing project.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.