Add types for big-sparse-array#68438
Conversation
|
@EvanHahn Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 68438,
"author": "EvanHahn",
"headCommitOid": "47a4eaacb0f38fcac49c0535a5e0f22962d112ec",
"mergeBaseOid": "fcefc87c2264c53445803f701bdba87e7246545d",
"lastPushDate": "2024-02-02T02:26:33.000Z",
"lastActivityDate": "2024-02-03T21:33:28.000Z",
"mergeOfferDate": "2024-02-03T18:49:17.000Z",
"mergeRequestDate": "2024-02-03T21:33:28.000Z",
"mergeRequestUser": "EvanHahn",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "big-sparse-array",
"kind": "add",
"files": [
{
"path": "types/big-sparse-array/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/big-sparse-array/big-sparse-array-tests.ts",
"kind": "test"
},
{
"path": "types/big-sparse-array/index.d.ts",
"kind": "definition"
},
{
"path": "types/big-sparse-array/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/big-sparse-array/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"EvanHahn"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2024-02-03T18:48:37.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1922676350,
"ciResult": "pass"
} |
|
🔔 @EvanHahn — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
peterblazejewicz
left a comment
peterblazejewicz
left a comment
There was a problem hiding this comment.
LGTM!
@EvanHahn thanks!
typescript-bot
added
Maintainer Approved
Self Merge
|
@EvanHahn: Everything looks good here. I am ready to merge this PR (at 47a4eaa) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
|
Ready to merge
|
3 participants
Please fill in this template.
pnpm test big-sparse-array.Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationIf not, do not conflict with the name of an npm package.dts-gen --dt, not by basing it on an existing project.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.