Add type definitions for nanobench#68221
Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom Jan 18, 2024
Merged
Add type definitions for nanobench#68221typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
nanobench#68221typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
Conversation
Contributor
|
@EvanHahn Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 68221,
"author": "EvanHahn",
"headCommitOid": "686c21e61444940ab5ba528ee4380ace922b56c6",
"mergeBaseOid": "52645639868fd0e137fa271d5e98d42675805205",
"lastPushDate": "2024-01-16T21:08:55.000Z",
"lastActivityDate": "2024-01-18T18:51:40.000Z",
"mergeOfferDate": "2024-01-18T18:47:46.000Z",
"mergeRequestDate": "2024-01-18T18:51:40.000Z",
"mergeRequestUser": "EvanHahn",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "nanobench",
"kind": "add",
"files": [
{
"path": "types/nanobench/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/nanobench/index.d.ts",
"kind": "definition"
},
{
"path": "types/nanobench/nanobench-tests.ts",
"kind": "test"
},
{
"path": "types/nanobench/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/nanobench/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"EvanHahn"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "navya9singh",
"date": "2024-01-18T18:47:05.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1894516916,
"ciResult": "pass"
} |
typescript-bot
added
the
New Definition
Contributor
|
🔔 @EvanHahn — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
navya9singh
approved these changes
Jan 18, 2024
typescript-bot
added
Maintainer Approved
Self Merge
Contributor
|
@EvanHahn: Everything looks good here. I am ready to merge this PR (at 686c21e) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
Contributor
Author
|
Ready to merge |
EvanHahn
added a commit
to digidem/comapeo-core
that referenced
this pull request
Jan 19, 2024
Types for nanobench were [recently added to DefinitelyTyped][0], so we can use them. The `benchmarks` directory is not currently type-checked, so this change has no impact, but it should make it easier to type-check in the future. [0]: DefinitelyTyped/DefinitelyTyped#68221
EvanHahn
added a commit
to digidem/comapeo-core
that referenced
this pull request
Jan 19, 2024
Types for nanobench were [recently added to DefinitelyTyped][0], so we can use them. The `benchmarks` directory is not currently type-checked, so this change has no impact, but it should make it easier to type-check in the future. [0]: DefinitelyTyped/DefinitelyTyped#68221
EvanHahn
added a commit
to digidem/multi-core-indexer
that referenced
this pull request
Jan 19, 2024
Types for nanobench were [recently added to DefinitelyTyped][0], so we can use them. The `benchmarks` directory is not currently type-checked, so this change primarily impacts editor tools. Similar to [another change in mapeo-core-next][1]. [0]: DefinitelyTyped/DefinitelyTyped#68221 [1]: digidem/comapeo-core#441
EvanHahn
added a commit
to digidem/multi-core-indexer
that referenced
this pull request
Jan 25, 2024
Types for nanobench were [recently added to DefinitelyTyped][0], so we can use them. The `benchmarks` directory is not currently type-checked, so this change primarily impacts editor tools. Similar to [another change in mapeo-core-next][1]. [0]: DefinitelyTyped/DefinitelyTyped#68221 [1]: digidem/comapeo-core#441
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.