[react-virtualized] Remove redundant props from List#58705
[react-virtualized] Remove redundant props from List#58705typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
List#58705Conversation
|
@EvanHahn Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 58705,
"author": "EvanHahn",
"headCommitOid": "a10a821243ccbd98a9f5151931594e59cde44c37",
"mergeBaseOid": "ef2b15cd773c7a2544043c2dd93e544ad6906cc7",
"lastPushDate": "2022-02-10T16:33:15.000Z",
"lastActivityDate": "2022-02-18T20:42:58.000Z",
"mergeOfferDate": "2022-02-18T18:25:46.000Z",
"mergeRequestDate": "2022-02-18T20:42:58.000Z",
"mergeRequestUser": "EvanHahn",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "react-virtualized",
"kind": "edit",
"files": [
{
"path": "types/react-virtualized/dist/es/List.d.ts",
"kind": "definition"
}
],
"owners": [
"kaoDev",
"guntherjh",
"wasd171",
"Stevearzh",
"mgoszcz2",
"brandonhall",
"sbusch",
"azmenak"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "andrewbranch",
"date": "2022-02-18T18:25:08.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1035136877,
"ciResult": "pass"
} |
typescript-bot
added
Popular package
|
Hey @EvanHahn, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
|
🔔 @kaoDev @guntherjh @wasd171 @Stevearzh @mgoszcz2 @brandonhall @sbusch @azmenak — please review this PR in the next few days. Be sure to explicitly select |
typescript-bot
added
Maintainer Approved
Self Merge
|
@EvanHahn: Everything looks good here. I am ready to merge this PR (at a10a821) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@kaoDev, @guntherjh, @wasd171, @Stevearzh, @mgoszcz2, @brandonhall, @sbusch, @azmenak: you can do this too.) |
|
Ready to merge |
… props from `List` by @EvanHahn
3 participants
#58648 updated
Grid's prop types, but those didn't propagate toListbecause it duplicates them. This removes the duplicated props and just pulls them off ofGrid.This means the autocomplete documentation may refer to
Gridinstead ofListin a few cases. Let me know if that's an issue and I can restore those.Add or edit tests to reflect the change.npm test react-virtualized.If changing an existing definition:
If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.