[react-virtualized] Loosen deferredMeasurementCache prop#58648
Conversation
|
@EvanHahn Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 58648,
"author": "EvanHahn",
"headCommitOid": "010912e878859dbfa988b822e5a87461ea34abf9",
"mergeBaseOid": "8a401fa673d1593f39151a16c1ca8e60bdee1e94",
"lastPushDate": "2022-02-07T22:16:36.000Z",
"lastActivityDate": "2022-02-09T21:15:28.000Z",
"mergeOfferDate": "2022-02-09T21:14:04.000Z",
"mergeRequestDate": "2022-02-09T21:15:28.000Z",
"mergeRequestUser": "EvanHahn",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "react-virtualized",
"kind": "edit",
"files": [
{
"path": "types/react-virtualized/dist/es/Grid.d.ts",
"kind": "definition"
}
],
"owners": [
"kaoDev",
"guntherjh",
"wasd171",
"Stevearzh",
"mgoszcz2",
"brandonhall",
"sbusch",
"azmenak"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "rbuckton",
"date": "2022-02-09T21:13:26.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "kaoDev",
"date": "2022-02-08T08:35:54.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1031994455,
"ciResult": "pass"
} |
typescript-bot
added
Popular package
|
Hey @EvanHahn, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
|
🔔 @kaoDev @guntherjh @wasd171 @Stevearzh @mgoszcz2 @brandonhall @sbusch @azmenak — please review this PR in the next few days. Be sure to explicitly select |
typescript-bot
added
the
Owner Approved
|
thanks @EvanHahn, I think this was actually intended from the beginning :) |
typescript-bot
added
Maintainer Approved
Self Merge
|
@EvanHahn: Everything looks good here. I am ready to merge this PR (at 010912e) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@kaoDev, @guntherjh, @wasd171, @Stevearzh, @mgoszcz2, @brandonhall, @sbusch, @azmenak: you can do this too.) |
|
Ready to merge |
…MeasurementCache` prop by @EvanHahn
4 participants
The
deferredMeasurementCacheprop claims to require aCellMeasurerCache, but it just requires things that comply with that interface. This PR updates that.I verified that nobody uses properties/methods of
deferredMeasurementCachethat aren't onCellMeasurerCacheInterface.Add or edit tests to reflect the change.npm test react-virtualized.If changing an existing definition:
deferredMeasurementCacheacross the repo: https://github.com/bvaughn/react-virtualized/search?q=deferredMeasurementCacheIf this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.