fix(helmet): correct CSP creation detail#44228
Merged
elibarzilay merged 1 commit intoDefinitelyTyped:masterfrom Apr 26, 2020
Merged
fix(helmet): correct CSP creation detail#44228elibarzilay merged 1 commit intoDefinitelyTyped:masterfrom
elibarzilay merged 1 commit intoDefinitelyTyped:masterfrom
Conversation
the `options` here are required in `helmet-csp` types, at runtime this throws exception: https://github.com/helmetjs/csp/blob/master/index.ts#L10 https://github.com/helmetjs/csp/blob/8bf3360019b61be93b8cf18a1bad8fe9fe43578f/lib/check-options/index.ts#L12 - maintainer added - test amended Thanks!
Contributor
|
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
typescript-bot
added
Perf: Same
Contributor
|
@peterblazejewicz Thank you for submitting this PR! 🔔 @cyrilschumacher @EvanHahn @BlueHatbRit @chdanielmueller - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
EvanHahn
approved these changes
Apr 25, 2020
Contributor
EvanHahn
left a comment
EvanHahn
left a comment
There was a problem hiding this comment.
Looks good.
IHelmetContentSecurityPolicyConfiguration should also mark directives as required, but that could be done in a followup.
typescript-bot
added
Owner Approved
Contributor
|
A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped! |
peterblazejewicz
added a commit
to peterblazejewicz/DefinitelyTyped
that referenced
this pull request
Apr 26, 2020
The `helmet-csp` throws an error at runtime if that property is missing. Marking this as required, see author's comment: DefinitelyTyped#44228 (review) Thanks!
5 tasks
peterblazejewicz
added a commit
to peterblazejewicz/DefinitelyTyped
that referenced
this pull request
Apr 29, 2020
The `helmet-csp` throws an error at runtime if that property is missing. Marking this as required, see author's comment: DefinitelyTyped#44228 (review) Thanks!
typescript-bot
pushed a commit
that referenced
this pull request
May 11, 2020
…red by @peterblazejewicz * feat(helmet): make `directives` of CSP config reuqired The `helmet-csp` throws an error at runtime if that property is missing. Marking this as required, see author's comment: #44228 (review) Thanks! * Remove non-related Prettier pragma Fixing PR comment
andreialecu
pushed a commit
to andreialecu/DefinitelyTyped
that referenced
this pull request
May 12, 2020
…SP config required by @peterblazejewicz * feat(helmet): make `directives` of CSP config reuqired The `helmet-csp` throws an error at runtime if that property is missing. Marking this as required, see author's comment: DefinitelyTyped#44228 (review) Thanks! * Remove non-related Prettier pragma Fixing PR comment
jjballano-qatium
pushed a commit
to jjballano-qatium/DefinitelyTyped
that referenced
this pull request
Jun 16, 2020
the `options` here are required in `helmet-csp` types, at runtime this throws exception: https://github.com/helmetjs/csp/blob/master/index.ts#L10 https://github.com/helmetjs/csp/blob/8bf3360019b61be93b8cf18a1bad8fe9fe43578f/lib/check-options/index.ts#L12 - maintainer added - test amended Thanks!
jjballano-qatium
pushed a commit
to jjballano-qatium/DefinitelyTyped
that referenced
this pull request
Jun 16, 2020
…SP config required by @peterblazejewicz * feat(helmet): make `directives` of CSP config reuqired The `helmet-csp` throws an error at runtime if that property is missing. Marking this as required, see author's comment: DefinitelyTyped#44228 (review) Thanks! * Remove non-related Prettier pragma Fixing PR comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
optionshere are required inhelmet-csptypes, at runtime thisthrows exception:
https://github.com/helmetjs/csp/blob/master/index.ts#L15
https://github.com/helmetjs/csp/blob/8bf3360019b61be93b8cf18a1bad8fe9fe43578f/lib/check-options/index.ts#L12
Thanks!
Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).