Merged
Conversation
maingoh
reviewed
Oct 3, 2019
Contributor
maingoh
left a comment
maingoh
left a comment
There was a problem hiding this comment.
In Makefile, I suggest replacing release rule by:
build: clean
./build_package.sh
With build_package.sh:
#!/bin/bash
set -e
rm -rf ./artifacts/*
# Build python packages
dmake test -d client:3.6
thomas-riccardi
force-pushed
the
dev-improve_integration
branch
2 times, most recently
from
f265f1f to
29c64e6
Compare
maingoh
reviewed
Oct 3, 2019
thomas-riccardi
force-pushed
the
dev-improve_integration
branch
4 times, most recently
from
1bd7486 to
235c587
Compare
maingoh
reviewed
Oct 4, 2019
Makefile
Outdated
| @@ -1,10 +1,10 @@ | |||
| all: release | |||
|
|
|||
| release: clean | |||
thomas-riccardi
force-pushed
the
dev-improve_integration
branch
from
235c587 to
914016d
Compare
It was previously broken because it tested on the installed egg.
We now split unit tests and egg tests (with demo.py) so code coverage
works on source code (and still test somehow the egg).
Also, move dev dependencies to requirements.dev.txt & bump them.
Also, store egg on host ./dist
Now the full workflow is split into 3 types of dmake services:
- client:<python_version_variant>:
- dmake build: linter
- dmake test: unit test
- build-egg: one service to build the universal egg
- dmake build: build egg
- dmake test: copy egg to host ./dist
- test-egg-py{2,3}:
- dmake test: test egg from host ./dist with demo.py
thomas-riccardi
force-pushed
the
dev-improve_integration
branch
from
914016d to
48d3a84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was previously broken because it tested on the installed egg.
We now split unit tests and egg tests (with demo.py) so code coverage
works on source code (and still test somehow the egg).
Also, move dev dependencies to requirements.dev.txt & bump them.