X Tutup
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: DEVBOX10/github-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: trunk
Choose a base ref
...
head repository: DEVBOX10/github-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: release-1.3
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 15 commits
  • 17 files changed
  • 5 contributors

Commits on Dec 2, 2020

  1. Sort latest PRs first when looking up PRs for a branch 

    Fixes cli#2452
    @mislav
    mislav committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    4eaefb3 View commit details
    Browse the repository at this point in the history

  2. Bump AlecAivazis/survey

    @mislav
    mislav committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    9068942 View commit details
    Browse the repository at this point in the history

  3. Document that reviewers can be teams (cli#2465) 

    Co-authored-by: Mislav Marohnić <mislav@github.com>
    @MaxHorstmann @mislav
    MaxHorstmann and mislav committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    b202608 View commit details
    Browse the repository at this point in the history

  4. Delete an error message that is not useful (and had a typo)

    @nilsvu @mislav
    nilsvu authored and mislav committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    a89d261 View commit details
    Browse the repository at this point in the history

  5. Properly check env auth tokens in CheckAuth

    @samcoe @mislav
    samcoe authored and mislav committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    20beaa1 View commit details
    Browse the repository at this point in the history

  6. Fix respecting chosen action in interactive issue create 

    The `action` variable started being shadowed in the `if` block in
6671106
    @mislav
    mislav committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    8650c2b View commit details
    Browse the repository at this point in the history

  7. Fix browser URL test on Windows

    @mislav
    mislav committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    eedac26 View commit details
    Browse the repository at this point in the history

  8. Fix "Continue in browser" for pr create coming from forks 

    Ensures that the `owner:` prefix is present when referencing the head branch
    @mislav
    mislav committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    da3f28e View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2020

  1. Prompt: avoid resetting PR/issue metadata if no option is selected

    @cristiand391 @mislav
    cristiand391 authored and mislav committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    39d8b80 View commit details
    Browse the repository at this point in the history

  2. don't reset previously added metadata

    @cristiand391 @mislav
    cristiand391 authored and mislav committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    1b234d0 View commit details
    Browse the repository at this point in the history

  3. Ensure efficient resolving of issue/pr create metadata to GraphQL IDs 

    For metadata types chosen in interactive flow, we fetch all records from
the API in order to be able to display a multi-select interface.

For metadata defined via command-line flags, we resolve records that can
be looked up directly, avoiding fetching the entirety of expensive
datasets (e.g. all members of an organization) if we can.

The new approach ensures efficient fetching when interactive flow is
combined with values from flags.
    @mislav
    mislav committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    bb0ab3a View commit details
    Browse the repository at this point in the history

  4. Make MetadataSurvey testable by accepting an interface

    @mislav
    mislav committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    c4c233a View commit details
    Browse the repository at this point in the history

  5. AskStubber now throws a more descriptive error when stubs do not match

    @mislav
    mislav committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    08309a5 View commit details
    Browse the repository at this point in the history

  6. Allow interactive pr create even if we failed to look up commits

    @mislav
    mislav committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    c788558 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'create-interactive-fix' into release-1.3

    @mislav
    mislav committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    1612979 View commit details
    Browse the repository at this point in the history
Loading
X Tutup