-
Notifications
You must be signed in to change notification settings - Fork 4
Comparing changes
Open a pull request
base repository: CogStack/CogStack-ModelServe
base: main
head repository: CogStack/CogStack-ModelServe
compare: feature-phoevos-ruff-format
- 8 commits
- 86 files changed
- 1 contributor
Commits on Dec 19, 2024
-
fix: Drop explicit ruff include list
Allow ruff to discover all files, instead of hardcoding every path which can be error prone, e.g. including "tests/" in the list meant that nested Python files were not being linted, while other paths were stale. There is no need for this list since we truly want to lint all Python files, which ruff does by default. Signed-off-by: Phoevos Kalemkeris <phoevos.kalemkeris@ucl.ac.uk>
Configuration menu - View commit details
-
Copy full SHA for 77c4850 - Browse repository at this point
Copy the full SHA 77c4850View commit details -
fix: Drop explicit ruff.format config
Drop the explicit ruff.format configuration from the pyproject.toml file since it corresponds to ruff's default values, making it harder for someone familiar with the tool to tell deviations from the default behaviour. Given that ruff strives to maintain compatibility with black, these defaults are unlikely to change. Signed-off-by: Phoevos Kalemkeris <phoevos.kalemkeris@ucl.ac.uk>
Configuration menu - View commit details
-
Copy full SHA for 5057a88 - Browse repository at this point
Copy the full SHA 5057a88View commit details -
fix: Cleanup ruff.lint configuration
Drop configuration settings that match ruff's default values (also see previous commit for the changes in ruff.format). Signed-off-by: Phoevos Kalemkeris <phoevos.kalemkeris@ucl.ac.uk>
Configuration menu - View commit details
-
Copy full SHA for 9b75c48 - Browse repository at this point
Copy the full SHA 9b75c48View commit details -
fix: Catch E501 and E226 linting errors
Drop E501 and E226 from ruff.lint's ignore list: * E226 does not appear in the codebase therefore there's no reason to include it there * Given that our line-length limit is already high, we shouldn't ignore E501 Ignoring C901 is not a good idea; the only reason I'm leaving it in is because it would require a lot of refactoring to fix it. We should address this in the future. Signed-off-by: Phoevos Kalemkeris <phoevos.kalemkeris@ucl.ac.uk>
Configuration menu - View commit details
-
Copy full SHA for 67e9269 - Browse repository at this point
Copy the full SHA 67e9269View commit details -
fix: Add isort to the list of ruff rules
Signed-off-by: Phoevos Kalemkeris <phoevos.kalemkeris@ucl.ac.uk>
Configuration menu - View commit details
-
Copy full SHA for b07f52d - Browse repository at this point
Copy the full SHA b07f52dView commit details -
Imports are highly inconsistent throughout the project, using a mix of absolute as well as explicit and implicit relative imports. For this reason, we have to explicitly specify the known first-party and local folders for isort to work correctly. Signed-off-by: Phoevos Kalemkeris <phoevos.kalemkeris@ucl.ac.uk>
Configuration menu - View commit details
-
Copy full SHA for 14c98fd - Browse repository at this point
Copy the full SHA 14c98fdView commit details -
fix: Reduce the line-length for ruff.lint to 100
I strongly believe that the limit should be reduced, but feel free to drop this commit if you disagree. Signed-off-by: Phoevos Kalemkeris <phoevos.kalemkeris@ucl.ac.uk>
Configuration menu - View commit details
-
Copy full SHA for e74b6ec - Browse repository at this point
Copy the full SHA e74b6ecView commit details
Commits on Dec 23, 2024
-
fix: Run ruff formatting and resolve issues
Run 'ruff check --fix' followed by 'ruff format' and resolve remaining errors manually. For the most part, the manual changes involved one of the 3 following actions: * Split long strings into multiple lines wrapped with parentheses * Refactor code, e.g. retrieve dict values and evaluate conditionals before using the results in f-strings * Move long strings to files (this can be done in many more places around the codebase) Signed-off-by: Phoevos Kalemkeris <phoevos.kalemkeris@ucl.ac.uk>
Configuration menu - View commit details
-
Copy full SHA for d63ba90 - Browse repository at this point
Copy the full SHA d63ba90View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff main...feature-phoevos-ruff-format