X Tutup
Skip to content

chore(client): Added a first prototype of check version#119

Merged
HunterNN merged 10 commits intoCodename-Recon:masterfrom
Dracks:feat/adding-check-updates
Jul 30, 2024
Merged

chore(client): Added a first prototype of check version#119
HunterNN merged 10 commits intoCodename-Recon:masterfrom
Dracks:feat/adding-check-updates

Conversation

@Dracks
Copy link
Contributor

@Dracks Dracks commented Jun 14, 2024

rel #26

Is not having an auto-updated, but at least is adding a check if there is a new version :)

Current screenshots:
image
image

How to test

  1. Modify the label Version in the main menu with some version name like v0.6.0
  2. Run the game

@Dracks Dracks requested a review from HunterNN as a code owner June 14, 2024 16:03
@HunterNN
Copy link
Contributor

HunterNN commented Jun 15, 2024

I recommend utilizing the global scene logic/globals/messages.tscn for incorporating such dialogues, either by using the existing accept dialog or creating another one inside this scene based on a Window. I also suggest reviewing the script attached to that scene.

I believe it might not be essential to include that button:
image

To replace this button: When the game checks for a new update, it should display this dialogue. The check is performed at the start of the game or when the player clicks on the version label. If the user clicks on the version label and the current version matches, the game can also provide a message stating that the latest version is up to date. Should the detected version not be in "v..." format, it should indicate that this isn't a release version hence cannot identify new updates. The dialogue could include an option for accessing the release page in that situation.

Regarding translation keys appearing: Will they be resolved when this PR gets merged?
image

@HunterNN
Copy link
Contributor

Also this plugin could be interesting: https://github.com/daenvil/MarkdownLabel

@Dracks Dracks marked this pull request as draft June 17, 2024 18:29
@Dracks Dracks force-pushed the feat/adding-check-updates branch from ad60ee4 to 3df36d1 Compare June 25, 2024 16:53
@Dracks Dracks force-pushed the feat/adding-check-updates branch from 3df36d1 to 13bedd2 Compare June 27, 2024 18:42
@Dracks Dracks force-pushed the feat/adding-check-updates branch from 13bedd2 to 41f5688 Compare July 4, 2024 17:13
@Dracks Dracks marked this pull request as ready for review July 5, 2024 15:52
Dracks and others added 5 commits July 13, 2024 09:03
Co-authored-by: HunterNN <stephan.kessler@outlook.com>
…at/adding-check-updates

# Conflicts:
#	client/assets/translations/base.pot
#	client/levels/menu.tscn
#	client/project.godot
@HunterNN HunterNN merged commit c4cc22c into Codename-Recon:master Jul 30, 2024
@Dracks Dracks deleted the feat/adding-check-updates branch July 30, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup