Add possibility to bind AMCP port to specific IP address#1663
Open
nerijus wants to merge 3 commits intoCasparCG:masterfrom
Open
Add possibility to bind AMCP port to specific IP address#1663nerijus wants to merge 3 commits intoCasparCG:masterfrom
nerijus wants to merge 3 commits intoCasparCG:masterfrom
Conversation
Julusian
requested changes
Sep 2, 2025
Member
Julusian
left a comment
Julusian
left a comment
There was a problem hiding this comment.
I was going to say that it would also be good to have this documented in the examples block in the config file, but it appears that this section of config is not expressed there, only in the active portion of the file, so maybe not
| const std::string& host, | ||
| unsigned short port); | ||
|
|
||
| AsyncEventServer(std::shared_ptr<boost::asio::io_context> io_context, |
Member
There was a problem hiding this comment.
I dont think this constructor without the host is being used or is helpful, and could be removed
| a.set_option(boost::asio::ip::tcp::acceptor::reuse_address(true)); | ||
| a.bind(endpoint); | ||
| a.listen(); | ||
| return a; |
Member
There was a problem hiding this comment.
is there a reason for this constructor being more verbose than before?
Previously it was doing acceptor_(*io_context_, tcp::endpoint(tcp::v4(), port)), so it looks like this could be done with something along the lines of return tcp::acceptor(*io_context_, endpoint); instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently AMCP port 5250 listens on all interfaces:
So it is possible for everyone from internet to connect to it and send commands (unless it is firewalled).
With this PR it is possible to specify IP addr like this:
Now it listens on
127.0.0.1only:This PR was made with the help of AI. If
<host>127.0.0.1</host>is omitted, then it behaves like before. The value should be IP addr, not hostname.