X Tutup
Skip to content

Output Settings Browse widget size fixed#23

Merged
techno-disaster merged 4 commits intoCCExtractor:masterfrom
ItsAdityaKSingh:output_screen
Jan 22, 2022
Merged

Output Settings Browse widget size fixed#23
techno-disaster merged 4 commits intoCCExtractor:masterfrom
ItsAdityaKSingh:output_screen

Conversation

@ItsAdityaKSingh
Copy link
Contributor

@ItsAdityaKSingh ItsAdityaKSingh commented Dec 30, 2021

Fixes: #21

Screenshot:
Screenshot 2021-12-30 at 2 02 38 PM

@ItsAdityaKSingh
Copy link
Contributor Author

@techno-disaster Could you review this?

@techno-disaster
Copy link
Member

Check #22 (comment)

@ItsAdityaKSingh
Copy link
Contributor Author

Check #22 (comment)

Sure. I would remove the banner back to true.

@ItsAdityaKSingh
Copy link
Contributor Author

@techno-disaster The required changes are done. You may merge this PR!

@techno-disaster
Copy link
Member

Looks like ci is failing

@ItsAdityaKSingh ItsAdityaKSingh force-pushed the output_screen branch 2 times, most recently from fc12e1f to 161eff7 Compare December 30, 2021 22:07
@ItsAdityaKSingh
Copy link
Contributor Author

@techno-disaster I have updated the PR, and the CI tests pass now. You may merge this!

@techno-disaster
Copy link
Member

techno-disaster commented Jan 1, 2022

updating packages can be done in a different PR

color: kBgLightColor,
),
child: Padding(
padding: const EdgeInsets.only(top: 10, left: 10),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to covering up of command!

Screenshot -
Screenshot 2022-01-01 at 6 42 12 PM

So removing padding makes space and no issue of rendering occurs as well.

@ItsAdityaKSingh ItsAdityaKSingh force-pushed the output_screen branch 2 times, most recently from fa1810d to bdc82b8 Compare January 12, 2022 07:12
@techno-disaster techno-disaster merged commit cc5cc38 into CCExtractor:master Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hidden Browse button in Output Settings

2 participants

X Tutup